[claude]

Requested by Richard Hartmann · Slack thread

Before: Only the original invoice reached the customer (with the order confirmation). A Rechnungsberichtigung or Stornorechnung created through POST /invoice-lifecycle/:id/{correction|cancellation} was stored and, with #282, copied to the accounting mailbox, but never sent to the customer. Its sent_at stayed null, the admin had to send the PDF by hand, and the dialog said "no mail to the customer".

After: A new correction or cancellation is emailed to the customer automatically, to the same recipients as the original invoice: To the purchaser, CC billing_email if set, stored PDF attached, through the Directus MailService / EMAIL_FROM (not the accounting SMTP). A successful send stamps sent_at, so the document counts as issued. If the send fails, the endpoint still answers 200, sent_at stays null and Slack is alerted. The response carries customer_mail: 'sent' | 'failed' | 'template_missing'. The invoice-actions UI shows it (as a warning when the mail did not go out), and the dialogs now say the document "geht automatisch per E-Mail an Kunde (Käufer, CC Rechnungs-E-Mail) und Buchhaltung".

How:

• New shared/invoice-customer-mail.ts:
  • sendInvoiceDocumentToCustomer sends the templated mail, then stamps sent_at. It never throws, and every outcome that needs a human goes to Slack: send failure, missing template, missing purchaser_email, or a sent_at stamp that cannot be stored.
  • recordInvoiceSent holds the sent_at retry logic (3 attempts with the same timestamp, then a Slack alert). ticket-order-processing now uses it instead of its own copy of the loop; its behaviour is unchanged.
• Templates live in the CMS (email_templates), like ticket_order_confirmation. Each document type gets its own key: ticket_invoice_correction and ticket_invoice_cancellation. Variables: purchaser_name, conference_title, order_number, invoice_number, invoice_date, reference_invoice_number, reference_invoice_date.
• shared/email-service.ts gains deliverTemplatedEmail, which returns 'sent' | 'template_missing' | 'failed'. A missing template is then an explicit failure (Slack alert naming the template, no mail sent) rather than a generic one. There is deliberately no fallback text in the code. sendTemplatedEmail is now a boolean wrapper around it, with the same behaviour as before.
• invoice-lifecycle: reads billing_email and calls the helper after the document row is stored and the accounting copy has been sent. The accounting copy is independent of the customer mail.

Regenerate: Regenerate never mails the customer, for originals and corrections alike. That matches how regenerate already works for originals. It is only possible while sent_at is null, i.e. when the customer mail did not go out. The flow is the same as for an original invoice whose confirmation mail failed: fix the data, regenerate, send the PDF by hand, set sent_at. Accounting still receives the regenerated version marked "ersetzt vorherige Fassung". A Stornorechnung is never the current document, so it cannot be regenerated at all. Side effect of this PR: a correction that was sent is now issued, so it can be corrected or cancelled in turn, and can no longer be regenerated.

Internal orders have no invoice, so nothing is sent (the endpoint still rejects them with 400).

Tests:

• Endpoint:
  • correction sent with To/CC, template key, data and the same PDF bytes, and sent_at stamped on the new row only;
  • cancellation sent with its own template and no CC when billing_email is empty;
  • send failure: 200, Slack alert, sent_at null, accounting copy still sent;
  • a throwing helper is contained;
  • missing template: template_missing, Slack alert and error log name the template, no other mail path used;
  • a sent correction blocks regenerate and allows a further correction;
  • regenerate after a failed customer mail sends no customer mail;
  • internal orders send nothing.
• Unit tests:
  • deliverTemplatedEmail: sent with CC and attachments, template missing, template read error, transport error;
  • recordInvoiceSent: retries with a stable timestamp, Slack alert;
  • customer-mail helper: stamp failure is still reported as sent, German dates, missing purchaser_email, a Slack failure is swallowed;
  • UI result messages.
• prettier:check, lint, test (48 suites, 676 tests) and build all pass.
• Test-merged locally with invoice-zugferd (Issue ticket invoices as ZUGFeRD / Factur-X e-invoices (EN 16931) #284): no conflicts, and the same four steps pass on the merge (51 suites, 703 tests).

Deployment:

1. Create the two templates in Directus, before or right after deploying. Without them, corrections and cancellations are still created, but customer_mail is template_missing and Slack is alerted:
   • Content → email_templates → + Create Item
   • key ticket_invoice_correction, name e.g. Rechnungsberichtigung an Kunde
   • subject Rechnungsberichtigung {{invoice_number}} zu Ihrer Rechnung {{reference_invoice_number}}
   • body_html: in the editor, click the source-code button (<>) and paste:
     <p>Guten Tag {{purchaser_name}},</p><p>anbei erhalten Sie die Rechnungsberichtigung Nr. {{invoice_number}} vom {{invoice_date}} zur Rechnung Nr. {{reference_invoice_number}} vom {{reference_invoice_date}} (Bestellung {{order_number}}, {{conference_title}}). Sie ersetzt die ursprüngliche Rechnung.</p><p>Viele Grüße<br>Ihr programmier.bar-Team</p>
   • Save. Then + Create Item again with key ticket_invoice_cancellation, name e.g. Stornorechnung an Kunde, subject Stornorechnung {{invoice_number}} zu Ihrer Rechnung {{reference_invoice_number}}, body_html:
     <p>Guten Tag {{purchaser_name}},</p><p>anbei erhalten Sie die Stornorechnung Nr. {{invoice_number}} vom {{invoice_date}} zur Rechnung Nr. {{reference_invoice_number}} vom {{reference_invoice_date}} (Bestellung {{order_number}}, {{conference_title}}). Eine Erstattung bereits gezahlter Beträge erfolgt separat.</p><p>Viele Grüße<br>Ihr programmier.bar-Team</p>
   • Wording can be adjusted freely; the suggestions are also in docs/tickets.md.
2. Rebuild the extension and restart the CMS. No schema change and no new env vars.
3. Optional cleanup: corrections and cancellations created before this PR always have sent_at = null, even if they were sent by hand. Set sent_at on those that were sent, so they count as issued and can no longer be regenerated.

Builds on #282 (and #280); merge after them.

---

Generated by Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
programmierbar-website	Ready	Preview	Oct 20, 2026 4:33pm UTC