fix(sha256_file): Improve the retval

kr-t · kr-t · commit 4998d1ed2584 · 2026-03-16T19:20:49.000+01:00
- set ret = 0 during normal completion (eof)
- do not use access(2)

Signed-off-by: Krisztian Szilvasi &lt;34309983+kr-t@users.noreply.github.com&gt;
diff --git a/src/shell/image/sha256_file.c b/src/shell/image/sha256_file.c
@@ -26,7 +26,7 @@ int sha256_file(const char *path, char *hash)
 
 	int fd = open(path, O_RDONLY);
 	if (fd < 0) {
-		return -1;
+		return -2;
 	}
 
 	struct stat finfo;
@@ -57,7 +57,6 @@ int sha256_file(const char *path, char *hash)
 		}
 
 		if (!bytes_read) {
-			ret = 0;
 			break;
 		}
 
@@ -66,6 +65,8 @@ int sha256_file(const char *path, char *hash)
 		total_bytes_read += bytes_read;
 	}
 
+	ret = 0;
+
 	sha256_finalize(&buff);
 	sha256_read_hex(&buff, hash);
 

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ int sha256_file(const char path, char hash)`
`26`	`26`
`27`	`27`	`int fd = open(path, O_RDONLY);`
`28`	`28`	`if (fd < 0) {`
`29`		`- return -1;`
	`29`	`+ return -2;`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`struct stat finfo;`
`@@ -57,7 +57,6 @@ int sha256_file(const char path, char hash)`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`if (!bytes_read) {`
`60`		`- ret = 0;`
`61`	`60`	`break;`
`62`	`61`	`}`
`63`	`62`
`@@ -66,6 +65,8 @@ int sha256_file(const char path, char hash)`
`66`	`65`	`total_bytes_read += bytes_read;`
`67`	`66`	`}`
`68`	`67`
	`68`	`+ ret = 0;`
	`69`	`+`
`69`	`70`	`sha256_finalize(&buff);`
`70`	`71`	`sha256_read_hex(&buff, hash);`
`71`	`72`