Repository navigation
ci: only require OpenMetrics spec version bump on PRs against main - #3148
Merged
Merged
Conversation
PRs targeting a feature branch such as om2-rc1 collect several spec changes that are released under a single version. Requiring a version bump on each of them is noise, so restrict the check to PRs against main, where the accumulated work gets its version. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
bwplotka
approved these changes
Oct 20, 2026
krajorama
added a commit
that referenced
this pull request
Oct 20, 2026
* chore: propose Jan as a maintainer Signed-off-by: Jan Fajerski <jfajersk@redhat.com> * build(deps): bump source-map-js from 1.2.1 to 1.2.2 Bumps [source-map-js](https://github.com/7rulnik/source-map-js) from 1.2.1 to 1.2.2. - [Release notes](https://github.com/7rulnik/source-map-js/releases) - [Changelog](https://github.com/7rulnik/source-map-js/blob/main/CHANGELOG.md) - [Commits](7rulnik/source-map-js@v1.2.1...v1.2.2) --- updated-dependencies: - dependency-name: source-map-js dependency-version: 1.2.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump sharp from 0.35.4 to 0.35.5 Bumps [sharp](https://github.com/lovell/sharp) from 0.35.4 to 0.35.5. - [Release notes](https://github.com/lovell/sharp/releases) - [Commits](lovell/sharp@v0.35.4...v0.35.5) --- updated-dependencies: - dependency-name: sharp dependency-version: 0.35.5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump postcss-selector-parser and postcss-preset-mantine Bumps [postcss-selector-parser](https://github.com/postcss/postcss-selector-parser) to 7.1.6 and updates ancestor dependency [postcss-preset-mantine](https://github.com/mantinedev/postcss-preset-mantine). These dependencies need to be updated together. Updates `postcss-selector-parser` from 6.1.4 to 7.1.6 - [Release notes](https://github.com/postcss/postcss-selector-parser/releases) - [Changelog](https://github.com/postcss/postcss-selector-parser/blob/main/CHANGELOG.md) - [Commits](postcss/postcss-selector-parser@6.1.4...7.1.6) Updates `postcss-preset-mantine` from 1.17.0 to 1.18.0 - [Commits](https://github.com/mantinedev/postcss-preset-mantine/commits) --- updated-dependencies: - dependency-name: postcss-selector-parser dependency-version: 7.1.6 dependency-type: indirect - dependency-name: postcss-preset-mantine dependency-version: 1.18.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps-dev): bump @modelcontextprotocol/sdk from 1.26.0 to 1.32.1 Bumps [@modelcontextprotocol/sdk](https://github.com/modelcontextprotocol/typescript-sdk) from 1.26.0 to 1.32.1. - [Release notes](https://github.com/modelcontextprotocol/typescript-sdk/releases) - [Commits](modelcontextprotocol/typescript-sdk@v1.26.0...1.32.1) --- updated-dependencies: - dependency-name: "@modelcontextprotocol/sdk" dependency-version: 1.32.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps-dev): bump proxy-addr from 2.0.7 to 2.0.8 Bumps [proxy-addr](https://github.com/jshttp/proxy-addr) from 2.0.7 to 2.0.8. - [Release notes](https://github.com/jshttp/proxy-addr/releases) - [Changelog](https://github.com/jshttp/proxy-addr/blob/master/HISTORY.md) - [Commits](jshttp/proxy-addr@v2.0.7...v2.0.8) --- updated-dependencies: - dependency-name: proxy-addr dependency-version: 2.0.8 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump next from 15.5.24 to 15.5.27 Bumps [next](https://github.com/vercel/next.js) from 15.5.24 to 15.5.27. - [Release notes](https://github.com/vercel/next.js/releases) - [Commits](vercel/next.js@v15.5.24...v15.5.27) --- updated-dependencies: - dependency-name: next dependency-version: 15.5.27 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * om2/gaugehistogram: prohibit negative count and bucket values Even though a negative count may arise from arithmetic operations from on native histograms, we don't believe that the resulting distribution means anything or is useful. Instead of changing the validation of histograms stored in Prometheus , we're making the specification more strict. Note: negative histograms may still be calculated in Prometheus and returned as PromQL query results or used as intermediate values in calculations. As explained by the native histograms specification: https://prometheus.io/docs/specs/native_histograms/#unary-minus-and-negative-histograms Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> * Add TEMPer USB thermal sensor exporter link Signed-off-by: Barry Postma <BAPostma@users.noreply.github.com> * Apply suggestion from @bwplotka Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com> * ci: only require OpenMetrics spec version bump on PRs against main (#3148) PRs targeting a feature branch such as om2-rc1 collect several spec changes that are released under a single version. Requiring a version bump on each of them is noise, so restrict the check to PRs against main, where the accumulated work gets its version. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> --------- Signed-off-by: Jan Fajerski <jfajersk@redhat.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Signed-off-by: Barry Postma <BAPostma@users.noreply.github.com> Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com> Co-authored-by: Jan Fajerski <jfajersk@redhat.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jan Fajerski <jan--f@users.noreply.github.com> Co-authored-by: Barry Postma <BAPostma@users.noreply.github.com> Co-authored-by: Julius Volz <julius.volz@gmail.com> Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version bump check added in c813541 fires on every PR that touches
docs/specs/om/open_metrics_spec_2_0.md, including PRs that target a featurebranch. That broke CI on #3139, which targets
om2-rc1.Feature branches collect several spec changes that are released together under a
single version, so a per-PR bump there is noise. This restricts the step to PRs
against
main, where the accumulated work gets its version. The ABNF check isunaffected and still runs for every PR.
🤖 Generated with Claude Code