collector/mountstats: add mountpoint label to NFS metrics#3690
Open
shravyavorugallu wants to merge 1 commit into
Open
collector/mountstats: add mountpoint label to NFS metrics#3690shravyavorugallu wants to merge 1 commit into
shravyavorugallu wants to merge 1 commit into
Conversation
Closes prometheus#2097 The mountstats NFS collector exports metrics labelled by `export` (the NFS server path), `protocol`, and `mountaddr`. When the same NFS server exports the same path to multiple local mount points the label set is ambiguous. This change adds a `mountpoint` label sourced from `procfs.Mount.Mount` (the local mount point path, e.g. /home or /scratch). The label is threaded through updateNFSStats() and applied to all three metric families: base, transport, and per-operation. No behaviour changes for existing single-mount configurations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2097
The mountstats NFS collector exports metrics labelled by
export(the NFS server path),protocol, andmountaddr. When the same NFS server exports the same path to multiple local mount points the label set is ambiguous.This change adds a
mountpointlabel sourced fromprocfs.Mount.Mount(the local mount point path, e.g. /home or /scratch). The label is threaded through updateNFSStats() and applied to all three metric families: base, transport, and per-operation.No behaviour changes for existing single-mount configurations.
Signed-off-by: Shravya Vorugallu Shravyavorugallu@gmail.com