Repository navigation
Fix WSL2 mountinfo parsing - #874
Merged
Merged
Conversation
2 tasks done
Member
Author
rtreffer
approved these changes
Oct 19, 2026
| }, | ||
| { | ||
| name: "9p Docker Desktop mount with space in super option path", | ||
| s: `3196 80 0:172 / /Docker/host rw,noatime - 9p C:\134Program\040Files\134Docker\134Docker\134resources rw,aname=drvfs;path=C:\Program Files\Docker\Docker\resources;symlinkroot=/mnt/,cache=5,access=client,msize=65536,trans=fd,rfd=3,wfd=3`, |
The WSL2 mountinfo doesn't correctly escape paths in the super options list. Refactor the parser to split the line in stages before and after the ` - ` separator. This makes the parsing logic simpler since we don't need to track the separator index anymore. * Fix a small bug in the option parser that doesn't deal with multiple `=` chars in the comma-separated option strings. * Fix `OptionalFields` to always return an empty map rather than nil for no optional fields. Fixes: #872 Signed-off-by: SuperQ <superq@gmail.com>
SuperQ
force-pushed
the
superq/fix_mountinfo_parse
branch
from
October 19, 2026 14:23
4ab99ae to
186969c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WSL2 mountinfo doesn't correctly escape paths in the super options list. Refactor the parser to split the line in stages before and after the
-separator. This makes the parsing logic simpler since we don't need to track the separator index anymore.=chars in the comma-separated option strings.OptionalFieldsto always return an empty map rather than nil for no optional fields.Fixes: #872