Repository navigation
CI: hadolint every Dockerfile and build changed ones on PRs - #3747
Merged
Merged
Conversation
Adds a docker workflow: hadolint over every tracked Dockerfile (failing when one is not listed) and a no-push build of the caddy and vector images when their Dockerfile changes. The bundle-only images and the cli image (already built by provider_image.yml) record why they are not built here. Fixes the two findings hadolint raised: caddy's robots.txt is written with printf rather than sh's undefined echo -e, and vector's apt source is written by redirect rather than through a pipe into tee.
goastler
marked this pull request as ready for review
November 6, 2026 05:07
goastler
enabled auto-merge (squash)
November 6, 2026 05:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
.github/workflows/docker.yml, run on PRs that touch a Dockerfile:hadolint: lints all five tracked Dockerfiles. Fails if a Dockerfile exists that is not in its list.docker-build: builds the caddy and vector images (never pushes) when this PR changed their Dockerfile, the workflow, or.hadolint.yaml..hadolint.yaml: apt/apk version pinning (DL3008/DL3018) is off, since a pinned distro package breaks rebuilds once the archive drops it. Info-level findings print but do not fail.# docker build opt-out: ...):publish_services.ymlbuilds them.packages/cliis already built on PRs byprovider_image.yml.robots.txtwithprintfinstead ofecho -e, which plainshdoes not define. The file contents are the same.| tee.Why a new workflow file
There is no shared docker stage yet, so this is a per-concern workflow next to
lint.yml,tests.ymland the others. It needs a code-owner review under the workflow-structure rule.Effect
A broken or badly written Dockerfile now fails on its PR, not later in a publish run.
Tests
actionlintpasses. hadolint 2.14.0 with this config passes on all five files locally.