Repository navigation
Caddy 2.5.13: ship chaddy's tcp-probe v2 lookup - #3838
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed: the Caddy image version goes from 2.5.12 to 2.5.13. The Dockerfile already pinned chaddy at #21 (since #3668), but no image was ever built from it. The image in use, built on 2 Nov, still has the old chaddy.
Why it matters: the old chaddy looks up TCP signals with a request that only fits an IPv4 address, and skips IPv6 connections entirely. In production, 0% of IPv6 sessions (about 30% of traffic) have any TCP signal, against ~98% of IPv4. chaddy #21 passes the connection's own socket to tcp-probe v2, which sees IPv6, and forwards the answer as
X-TCP-Probe. The legacyX-TLS-Tcp-*headers are unchanged, so nothing that reads them changes.Built and checked:
prosopo/caddy:2.5.13is pushed (notlatest).caddy build-infoshows chaddyv0.0.0-20261109164248-faf69736830d. Adapting a production node's live Caddyfile with its env gives byte-identical JSON to the current image. On staging, an IPv6 request now arrives at the provider with a fullX-TCP-Proberecord (MSS, SYN TTL, options, RTT), and IPv4 requests still get every legacy header. For the provider to store the record, it also needs #3837 (its schema rejected the real record).To roll out: retag
latestto 2.5.13 and recreatecaddyon each pronode, after tcp-probe is up.🤖 Generated with Claude Code