Repository navigation
Forward framed checkbox input to the host page - #3849
Merged
Merged
Conversation
forgetso
enabled auto-merge (squash)
November 12, 2026 17:00
forgetso
disabled auto-merge
November 12, 2026 17:12
The frame is removed as soon as the widget redraws, so it can never answer a flush. The host now records forwarded input into the page's early capture while it is still recording, which every solve already merges. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed: Input inside the framed checkbox (mouse moves, clicks, touches) is now sent to the host page. Taps that happen before the page's behaviour detector has started, such as tapping as soon as the page loads, are kept in the page's early capture.
Effect: Phone users who only tap the checkbox no longer submit empty behaviour data.
Tests: Unit tests cover the frame's page offset, recording a forwarded tap after its frame has been removed, and leaving later input to the detector.
🤖 Generated with Claude Code