Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LastModified()asserts that the response'sDateheader can be parsed. An empty or unparseable Date therefore makes an otherwise readable HTTP request raiseAssertionErrorbefore its body is returned. Skip heuristic expiry in that case, matching the existing handling of an invalid Last-Modified header and the controller's invalid-Date recovery added in #449.Adds regressions for empty and unparseable Date values, including unchanged response headers. Both fail on the base. The full suite passes on Python 3.10.20 and 3.13.14 (117 tests each),
make lintpasses, and the strict Sphinx build passes. A separately installed wheel passed actual localhost HTTP requests: invalid/empty Date responses return their bodies without heuristic expiry or caching, while a valid Date still produces a cache hit on the second request.Changed-file formatting and spelling checks pass. Optional whole-tree checks retain exactly the baseline findings: Ruff formatting in unchanged
controller.py/redis_cache.py, and two existing spelling findings intest_cache_control.py. Other interpreters/platforms and upstream CI remain unverified.AI disclosure: prepared with OpenAI Codex. A separate Codex agent independently reviewed exact commit
90db73aand independently ran the focused regressions and localhost HTTP consumer. This is automated review, not human maintainer review.