Repository navigation
Honor timezone offsets in datetime_to_header - #484
Closed
pacocartones wants to merge 1 commit into
Closed
pacocartones wants to merge 1 commit into
pacocartones wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
datetime_to_header()currently treats the wall-clock fields of an aware datetime as UTC. For example, 12:00 at UTC+02 is formatted as 12:00 UTC rather than 10:00 UTC.Use
utctimetuple()beforecalendar.timegm()to honor the offset. Preserve existing output for UTC and naive datetimes. Tests cover positive and negative half-hour offsets crossing calendar days, UTC, and naive inputs.Scope: built-in callers already supply UTC datetimes, so their behavior is unchanged. This fixes direct use of the module helper, including custom heuristics supplying an aware non-UTC datetime. It is not a fix for the normal built-in expiry path or all timezone-related caching behavior.
Validation on Python 3.12 in WSL:
git diff --checkpass; tests lint clean. Source UP035/RUF012 findings also exist on the unchanged base.The focal harness loads the complete real heuristics module with importlib and extracts only the new test class via AST to avoid unavailable requests/server test dependencies. The full heuristics/package suites and other Python versions were not run. No dependencies were installed.