fix(empty_voices): update temp_channels config after successful delete#153
Merged
psykzz merged 1 commit intoMay 27, 2026
Conversation
Move the temp_channels config removal to after channel.delete() succeeds. Previously, the channel ID was removed from config before deletion was attempted, meaning a Forbidden or HTTPException would leave the channel alive in Discord but untracked. Simplify the NotFound handler to reuse the already-fetched guild_group and temp_channels variables instead of re-fetching inside a nested try/except. Fixes #147 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
psykzz
deleted the
msmith-riot/issue-147-fix-temp-channel-tracking-on-failed-dele-7fa9af
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
try_delete_channel(), the channel ID was removed fromtemp_channelsconfig before
channel.delete()was attempted. If the deletion raiseddiscord.Forbiddenordiscord.HTTPException, the channel remained alive inDiscord but was silently dropped from tracking -- meaning future cleanup and
validation passes would never see it.
Fix: move the config update to after
channel.delete()returnssuccessfully. On any exception that leaves the channel alive (Forbidden,
HTTPException), the config is untouched and the channel stays tracked. The
NotFoundcase (channel already gone externally) is still cleaned upcorrectly by the existing handler, which is also simplified to reuse the
already-fetched
guild_group/temp_channelsvariables instead ofre-fetching inside a nested try/except.
Fixes: #147