Repository navigation
docs: illustrate nested wrapper execution order - #778
Open
tonyzedginidze wants to merge 1 commit into
Open
tonyzedginidze wants to merge 1 commit into
tonyzedginidze wants to merge 1 commit into
Conversation
RonnyPfannschmidt
requested changes
Oct 12, 2026
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
Member
There was a problem hiding this comment.
an svg with a embedded font instead of a mermaid diagram - are you serious ?!
Member
|
note that even if it is meermaid, its one of the worse ways zo visualize what exactly hook wrappers do because sequence diagrams are not meant for expressing closure nesting - they are meant for expressing actor interactions one would make sense for xdist, for pluggy internals something else is needed |
Author
|
hi @RonnyPfannschmidt Otherwise if strictly mermaid is required, I will replace the PR as well |
tonyzedginidze
force-pushed
the
codex/docs-wrapper-sequence
branch
from
October 13, 2026 07:13
46072fe to
d5bbf1f
Compare
tonyzedginidze
force-pushed
the
codex/docs-wrapper-sequence
branch
from
October 13, 2026 07:17
d5bbf1f to
749d1c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, let me know if something like this is allowed. If no mention of svg website preferred, its fine I can also remove.