Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #761.
If a historic hook implementation or its result callback raises during
register(), the plugin currently remains registered with only some implementations installed. This prevents a clean retry and can leave hooks running from a failed plugin. Remove the failed registration before propagating the original exception. Preserve unrelated registered plugins and specifications added by user code during replay.Regression coverage includes implementation and result-callback failures,
RuntimeErrorandKeyboardInterrupt, retry after failure, validation against a specification introduced during replay, and preservation of a replacement plugin installed under the same name during failed replay.Validation:
Tests use
PYTHONPATH=src uv run --no-default-groups --with 'pytest>=8' --with 'pytest-benchmark>=4' pytest -q: the checked-in lock selects old test tools that cannot run on modern Python. The lock is unchanged. User callback side effects outside the failed registration are retained.Prepared with OpenAI Codex.