[bluetech]

No description provided.

[RonnyPfannschmidt]

thanks for getting this started

i wish my pr stack was included fully but i recognize that it take way longer than ihoped

[bluetech]

The deploy failed with this error:

  * `invalid-publisher`: valid token, but no corresponding publisher (Publisher with matching claims was not found)
  
  This generally indicates a trusted publisher configuration error, but could
  also indicate an internal error on GitHub or PyPI's part.
  
  
  The claims rendered below are **for debugging purposes only**. You should **not**
  use them to configure a trusted publisher unless they already match your expectations.
  
  If a claim is not present in the claim set, then it is rendered as `MISSING`.
  
  * `sub`: `repo:pytest-dev/pluggy:ref:refs/tags/1.7.0`
  * `repository`: `pytest-dev/pluggy`
  * `repository_owner`: `pytest-dev`
  * `repository_owner_id`: `8897583`
  * `workflow_ref`: `pytest-dev/pluggy/.github/workflows/deploy.yml@refs/tags/1.7.0`
  * `job_workflow_ref`: `pytest-dev/pluggy/.github/workflows/deploy.yml@refs/tags/1.7.0`
  * `ref`: `refs/tags/1.7.0`
  * `environment`: `MISSING`

Looking into it.

[bluetech]

I don't have pluggy PyPI permissions, so I can't check what is configured there. From the error message, I assume that it requires some environment. If we copied the setup from pytest, that would be deploy. So we'd need a patch like this:

diff --git i/.github/workflows/deploy.yml w/.github/workflows/deploy.yml
index 8c8fef9..713ac24 100644
--- i/.github/workflows/deploy.yml
+++ w/.github/workflows/deploy.yml
@@ -28,6 +28,7 @@ jobs:
     needs: [package]
     if: github.event_name == 'push' && startsWith(github.event.ref, 'refs/tags') && github.repository == 'pytest-dev/pluggy'
     runs-on: ubuntu-latest
+    environment: deploy
     permissions:
       id-token: write
     steps:

@RonnyPfannschmidt would you mind taking a look at the PyPI configuration and letting me know what it requires?

[RonnyPfannschmidt]

wrong workflow name, lets keep the deploy name
i'll add a new deployment

[RonnyPfannschmidt]

i created a new deployment for pluggy that supposedly works right now

after the release lets set a environment name and tighten it a bit more

[bluetech]

Thanks Ronny, I see it's available in PyPI now, so merging this PR.

I'll let someone with PyPI permissions to add the environment, that'd be better for debugging.