tighten Node.parent to Collector and resolve the resulting typing issues #8244

Activity

1. RonnyPfannschmidt

   added

   type: backward compatibilitymight present some backward compatibility issues which should be carefully noted in the changelogmight present some backward compatibility issues which should be carefully noted in the changelog

   type: refactoringinternal improvements to the codeinternal improvements to the code

   on Jan 16, 2021
2. obestwalter

   added this to detangle node structureon Jun 18, 2024
3. obestwalter

   moved this to To do in detangle node structureon Jun 18, 2024
4. RonnyPfannschmidt commented on Sep 13, 2026

   

   RonnyPfannschmidt

   on Sep 13, 2026

   MemberAuthor

   More actions

   I asked Claude Opus 5 (via Claude Code) to check whether this issue is still live. The investigation and the text below are its work; I read it and I am posting it.

   Resolved by #14758.

   Node.parent is now annotated Collector | None (src/_pytest/nodes.py:152), and Collector.from_parent takes parent: Collector (nodes.py:219) — the tightening this issue asked for. The change landed as part of "Replace string nodeids with a structured NodeId internally" (431f3e1), which is why it was never linked here.

   Closing as resolved.
5. RonnyPfannschmidt

   closed this as completedon Sep 13, 2026