Repository navigation
Extract the parametrization core into _pytest.parametrize - #14856
Draft
RonnyPfannschmidt wants to merge 2 commits into
Draft
RonnyPfannschmidt wants to merge 2 commits into
RonnyPfannschmidt wants to merge 2 commits into
Conversation
RonnyPfannschmidt
force-pushed
the
refactor/extract-parametrize
branch
from
August 11, 2026 10:45
ceb60f3 to
7588088
Compare
pyba-chronographer
Bot
added
the
bot:chronographer:provided
This was referenced Aug 11, 2026
RonnyPfannschmidt
force-pushed
the
refactor/extract-parametrize
branch
from
August 11, 2026 18:34
7588088 to
a114fc8
Compare
This was referenced Aug 11, 2026
RonnyPfannschmidt
force-pushed
the
refactor/extract-parametrize
branch
from
August 11, 2026 18:39
a114fc8 to
d0aabf4
Compare
RonnyPfannschmidt
force-pushed
the
refactor/extract-parametrize
branch
2 times, most recently
from
August 11, 2026 19:25
73227f0 to
8bc239b
Compare
RonnyPfannschmidt
force-pushed
the
refactor/extract-parametrize
branch
from
September 15, 2026 11:51
8bc239b to
70a056e
Compare
RonnyPfannschmidt
force-pushed
the
refactor/extract-parametrize
branch
from
September 23, 2026 07:00
70a056e to
b78d468
Compare
RonnyPfannschmidt
force-pushed
the
refactor/extract-parametrize
branch
2 times, most recently
from
October 11, 2026 07:26
236e0ce to
1981cd8
Compare
TestReport.from_item_and_call asserted reportinfo() yields a line number. Items which cannot point at a line -- non-Python items legitimately report None -- crashed with an INTERNALERROR when skipped via a marker. Report the location without a line instead.
Move IdMaker, CallSpec and _ascii_escaped_by_config out of python.py into a new module, together with the long-str id strategy literals they own. python.py imports them back, so _pytest.python.CallSpec and the CallSpec2 alias keep resolving as before. Pure move, no behaviour change. The two CollectError call sites go through a small _collect_error() helper which imports nodes lazily, so nodes stays free to import this module later.
RonnyPfannschmidt
force-pushed
the
refactor/extract-parametrize
branch
from
October 14, 2026 20:28
1981cd8 to
f1865ac
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Stack: #14855 -> #14856 -> #14769 -> #14857 -> #14858. Review only the last commit.
Pure move, no behaviour change.
IdMaker,CallSpecand_ascii_escaped_by_configmove out ofpython.pyinto a new
_pytest.parametrize, together with the long-str id strategyliterals they own.
python.pyimports them back, so_pytest.python.CallSpecand the
CallSpec2alias keep resolving as before.The two
CollectErrorcall sites go through a small_collect_error()helperwhich imports
nodeslazily, sonodesstays free to import this module later.Groundwork for #3926: the parametrization core has to be reachable from
non-Python collectors.