Repository navigation
Conversation
Co-authored-by: Claude <noreply@anthropic.com>
…/SemTiOne/pytest into fix-2388-syntax-error-crash-line
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Bruno Oliveira <bruno@soliv.dev>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
When the file:line:col crash line is shown (pytest-dev#14899), the stdlib File/line header in the E-block only repeats that location. Co-authored-by: Cursor <cursoragent@cursor.com>
pluggy 1.7.0 documents list_plugin_distinfo with a private pluggy._compat.DistFacade cross-reference that Sphinx cannot resolve under nitpicky mode, breaking RTD with fail_on_warning. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Thanks, but why are my commits included here? |
Member
|
this is a stacked pr jsut without a github pr stack feautre being used |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #14899 / #14994: during collection, when the
FILE:LINE:COLUMNcrash line is appended, drop the now-redundant stdlibFile "...", line Nheader from the E-block. Keep the source and caret lines, and leave the no-column fallback and runtime--tb=*paths unchanged.Depends on #14899 (this branch is based on it; once that merges, this PR's diff shrinks to the collection-path change alone).
Before:
After:
Test plan
Collection of
def broken(:shows caret +file:line:col, noFileheaderIndentationError collection likewise omits the header
SyntaxError without offset still keeps the
FileheaderRuntime
--tb=longstill shows theFileheadertesting/code+ collection/terminal/reports/junitxml (784 passed)pre-commit runon touched filesInclude documentation when adding new features.
Include new tests or update existing tests when applicable.
Allow maintainers to push and squash when merging my commits.
Closes Redundant
File ..., line Nblock in SyntaxError output #14994If AI agents were used, they are credited in
Co-authored-bycommit trailers.Create a new changelog file in the
changelogdirectory (14994.improvement.rst).Add yourself to
AUTHORSin alphabetical order.