Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Ignore the undocumented DistFacade class reference inherited from Pluggy in the strict documentation build. Fixes pytest-dev#15190.
Lothnic
force-pushed
the
codex/docs-pluggy-distfacade
branch
from
October 16, 2026 04:44
eb06190 to
0d6b61d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15190.
With Pluggy 1.7.0,
tox -e docsfails because the inheritedPluginManager.list_plugin_distinfodocstring links to the undocumented private classpluggy._compat.DistFacade. Sphinx cannot resolve that target, and the documentation build treats warnings as errors.Add that exact class reference to the existing
nitpick_ignorelist under undocumented third-party types. Other missing references still fail the build. A contributor changelog entry records the fix.Validation:
tox -e docspasses with Python 3.14.6, Pluggy 1.7.0 and Sphinx 9.1.0.sphinx-build -E -a -j 4 -W --keep-going -b html) also passes.git diff --checkpass.tox -e py314completed with 4,695 passed, 48 skipped, 17 xfailed and 4 xpassed. The change only affects documentation configuration.The full pre-commit run could not complete because DNS resolution failed while fetching a hook dependency from GitHub.
AI assistance was used for investigation, implementation and preparation of this description.