Repository navigation
Trim short test summary lines to the terminal width when color is enabled - #15216
Open
LemonCondor wants to merge 2 commits into
Open
LemonCondor wants to merge 2 commits into
LemonCondor wants to merge 2 commits into
Conversation
_get_line_with_reprcrash_message() measured the "FAILED <nodeid>" prefix with wcswidth() after markup was applied. The ANSI escape codes are control characters, so wcswidth() returned -1 and the message was trimmed to the full terminal width plus one column, making every colored summary line overflow by the width of its prefix. Strip the escape sequences before measuring the prefix.
pyba-chronographer
Bot
added
the
bot:chronographer:provided
Co-authored-by: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When color output is enabled, lines in the short test summary can exceed the terminal width because ANSI color codes distort the width calculation. This change strips color codes before measuring line widths and adds a regression test comparing colored and uncolored output.
Reproduce: a test failing with a long message (
assert 0, "x" * 300), run withCOLUMNS=80 pytest -rf --color=yes: theFAILED ...summary line is wider than 80 columns, while with--color=noit is trimmed to 80.Co-authored-bycommit trailers. (AI assistance: Claude Code; credited in the commit trailer.)changelogdirectory.AUTHORSin alphabetical order.