Repository navigation
Annotate FixtureRequest.node as Any and document why - #15227
Open
RonnyPfannschmidt wants to merge 2 commits into
Open
RonnyPfannschmidt wants to merge 2 commits into
RonnyPfannschmidt wants to merge 2 commits into
Conversation
Refs #13888. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FbVKGSuPZFfJpPHTPANBQa
RonnyPfannschmidt
added
the
skip news
Claude
Contrabang
reviewed
Oct 20, 2026
Strict pyright reports an unannotated return as Unknown, so spell out the intended Any. Refs #13888. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FbVKGSuPZFfJpPHTPANBQa
RonnyPfannschmidt
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ronny · project thread
🤖 Written by Claude Opus 5.5 via Claude Code for the pytest maintainers; I prompted it, it did the work, I read it.
FixtureRequest.nodeis deliberately not typed asNode. See bluetech's reasoning in #13888 (comment). Several PRs have tried to add that annotation (#15103, #15226), and it would break typed user code such asrequest.node.functionorrequest.node.rep_callunder mypy.This PR:
FixtureRequest.nodethat explains the decision and links the reasoning;-> Any. Strict pyright reports an unannotated return asUnknown(reportUnknownMemberTypeon everyrequest.nodeaccess). An explicitAnyfixes that, and mypy treats both forms the same. Suggested by Contrabang in review.Verified: pyright strict on
request.node.nodeid/.functiongoes from 6 errors to 0, andmypy --strictstays clean.Refs #13888.
🤖 Generated with Claude Code
https://claude.ai/code/session_01FbVKGSuPZFfJpPHTPANBQa