Skip to content

Improve astuple performance for nested atomic sequences #1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hynek merged 3 commits into from
Oct 13, 2026
Merged

Improve astuple performance for nested atomic sequences #1636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ce9550
Improve astuple nested atomic sequence performance
Johnny-Kao Oct 1, 2026
0c504ac
Add changelog for astuple sequence optimization
Johnny-Kao Oct 1, 2026
ce52bb2
Merge branch 'main' into perf/astuple-nested-atomic
hynek Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/1636.change.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improved `attrs.astuple()` performance for atomic values nested in sequences by avoiding unnecessary attrs-class detection.
2 changes: 1 addition & 1 deletion src/attr/_funcs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ def astuple(
tuple_factory=tuple_factory,
retain_collection_types=retain,
)
if has(j.__class__)
if type(j) not in _ATOMIC_TYPES and has(j.__class__)
else j
)
for j in v
Expand Down
Loading