Repository navigation
fix: preserve slots declared on slotted attrs classes - #1642
Open
DawnofGenX wants to merge 2 commits into
Open
DawnofGenX wants to merge 2 commits into
DawnofGenX wants to merge 2 commits into
Conversation
Iterate the already-filtered list of the class's own slots instead of re-testing each own slot against the combined slot_names in the descriptor cleanup loop. The popped set is unchanged (a name is only in own_new_slots when it is added to slot_names), but the redundant membership test introduced a branch that is never taken for valid input, which the 100% branch-coverage gate rejects.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Slots declared on a slotted attrs class are lost:
Fix
Preserve slots declared on the slotted attrs class itself, not just inherited slots.
Verification