Repository navigation
Improve astuple performance for atomic dictionary keys and values - #1646
Open
Johnny-Kao wants to merge 1 commit into
Open
Johnny-Kao wants to merge 1 commit into
Johnny-Kao wants to merge 1 commit into
Conversation
Johnny-Kao
marked this pull request as ready for review
October 20, 2026 02:42
6 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hi again!
Following up on the merged #1636, I noticed that
astuple()still performs unnecessaryhas()checks when processing dictionary keys and values.I made the same small change for dictionary keys and values, so
astuple()can skip unnecessary checks.For dictionaries with 1,000 atomic entries, this makes it 2.62× faster, with no change in behavior.
Details (for reference only)
CPython 3.14, Linux, 1,000 dictionary entries:
Validation:
Pull Request Checklist
mainbranch..pyi).typing_tests/baseline.pyor, if necessary,typing_tests/mypy.py.attr/__init__.pyi, they've also been re-imported inattrs/__init__.pyi.docs/api.rstby hand.@attr.s()and@attrs.define()have to be added by hand too.versionadded,versionchanged, ordeprecateddirectives..rstand.mdfiles is written using semantic newlines.changelog.d.