Repository navigation
fix: send sync-collection with Depth: 0 - #818
Merged
Merged
Conversation
RFC 6578 section 3.2 defines the sync-collection REPORT for Depth: 0 only; other values result in 400. The shared report helper hard-coded Depth: 1 (correct for calendar-query) and the async sync_collection() defaulted to 1. The helper now takes a depth, and both sync paths send 0. A probe of all 14 docker and 7 external test servers found identical results at both depths. Prompt: The other session reports: A caldav library bug the page reveals: caldav sends sync-collection with Depth: 1, but RFC 6578 defines it for Depth: 0 only. All five servers tolerate it. The cause is _request_report_build_resultlist in caldav/collection.py, which hard-codes depth 1. That is a fix in caldav, not a probe. [finding relayed from another AI session] Followup-Prompt: All the docker test servers are up. Please verify that all of them and all external servers can handle Depth 0 Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
tobixen
force-pushed
the
fix/sync-collection-depth-0
branch
from
October 24, 2026 00:02
0e24e45 to
7701e07
Compare
SashankBhamidi
approved these changes
Oct 24, 2026
SashankBhamidi
left a comment
SashankBhamidi
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Credits to @SashankBhamidi for finding this one in PyCalendar/calendaring-sync#33
Testing has been done towards all servers I have access to, none of them cares about the Depth header.
Commit message:
🤖 Generated with Claude Code