Skip to content
This repository was archived by the owner on Jun 22, 2025. It is now read-only.

#765 Drop pkg_resources#766

Merged
samuelhwilliams merged 5 commits into
python-eel:mainfrom
v01d-gh:drop_pkg_resources
Jun 22, 2025
Merged

#765 Drop pkg_resources#766
samuelhwilliams merged 5 commits into
python-eel:mainfrom
v01d-gh:drop_pkg_resources

Conversation

@v01d-gh

@v01d-gh v01d-gh commented Jun 15, 2025

Copy link
Copy Markdown
Contributor

Closes #765

  1. Used importlib_resources instead of pkg_resources as per migration guide.
  2. Added python 3.13 support to tox.ini.

I did not use std importlib.resources to support older python versions. The minimum required importlib-resources 1.3 implements importlib.resources from python 3.9 and should work correctly for Python 3.5+ and 2.7+.

@v01d-gh

v01d-gh commented Jun 15, 2025

Copy link
Copy Markdown
Contributor Author

Should I bump the version?

@samuelhwilliams

samuelhwilliams commented Jun 16, 2025

Copy link
Copy Markdown
Collaborator

I'm going to give this a bit of thought, but I did say that if a PR went up I'd consider merging it.

Regardless of if I merge this, I will probably archive the project afterwards as Eel is very much unmaintained, unfortunately.

@samuelhwilliams

Copy link
Copy Markdown
Collaborator

all of the tests are failing - if you want this merged, please take a look 🙇‍♂️

@v01d-gh

v01d-gh commented Jun 19, 2025

Copy link
Copy Markdown
Contributor Author

@samuelhwilliams

@v01d-gh

v01d-gh commented Jun 19, 2025

Copy link
Copy Markdown
Contributor Author

the tests will definitely pass someday...

@v01d-gh

v01d-gh commented Jun 19, 2025

Copy link
Copy Markdown
Contributor Author

@samuelhwilliams start workflows, please 🙏

@v01d-gh

v01d-gh commented Jun 19, 2025

Copy link
Copy Markdown
Contributor Author

So, I would say that tests for all OS have been passed.

@v01d-gh

v01d-gh commented Jun 20, 2025

Copy link
Copy Markdown
Contributor Author

@samuelhwilliams, is there anything else I'm expected to do in this pull request?

@samuelhwilliams

samuelhwilliams commented Jun 22, 2025

Copy link
Copy Markdown
Collaborator

This isn't actually usable as it stands - need to add importlib_resources to setup.py please 🙏

Trying to package an Eel application fails on this branch.

@v01d-gh

v01d-gh commented Jun 22, 2025

Copy link
Copy Markdown
Contributor Author

@samuelhwilliams, try again, please. I pray to God we have pyproject.toml and uv today 🙏🕯️.

@samuelhwilliams samuelhwilliams merged commit 163d5c3 into python-eel:main Jun 22, 2025
19 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setuptools removal 2025-11-30

3 participants