Skip to content

[3.14] gh-134837: Correct and improve base85 documentation for base64 module (GH-145843)#149743

Merged
serhiy-storchaka merged 4 commits into
python:3.14from
serhiy-storchaka:backport-e667d62-3.14
May 15, 2026
Merged

[3.14] gh-134837: Correct and improve base85 documentation for base64 module (GH-145843)#149743
serhiy-storchaka merged 4 commits into
python:3.14from
serhiy-storchaka:backport-e667d62-3.14

Conversation

@serhiy-storchaka
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka commented May 12, 2026 •
edited by bedevere-app Bot
Loading

@dhdaines @serhiy-storchaka
[3.14] pythongh-134837: Correct and improve base85 documentation for …
a49e99d 
…base64 and binascii modules (pythonGH-145843)

(cherry picked from commit e667d62)

Co-authored-by: David Huggins-Daines <dhd@ecolingui.ca>
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.13 bugs and security fixes label May 12, 2026
This was referenced May 12, 2026
Closed
Merged
@read-the-docs-community
Copy link
Copy Markdown

read-the-docs-community Bot commented May 12, 2026 •
edited
Loading

Documentation build overview

📚 cpython-previews | 🛠️ Build #32674716 | 📁 Comparing f828b65 against main (e472f6d)

  🔍 Preview build  

390 files changed · ± 374 modified · - 16 deleted

± Modified

- Deleted

@serhiy-storchaka
Copy link
Copy Markdown
Member Author

serhiy-storchaka commented May 12, 2026

@dhdaines, please look if anything more is needed for this backport.

There are no changes in the binascii module, because it only supports Base85 since 3.15. There are less other parameters, most important -- there is no pad parameter for Z85 encoder.

@dhdaines
Copy link
Copy Markdown
Contributor

dhdaines commented May 12, 2026

Great! I will take a look a bit later. Given that there's no pad parameter and the default is False, the behaviour of the Z85 encoder is non-conforming (ZeroMQ specifies that Z85 data should always be padded to a multiple of 4 bytes input / 5 bytes output), so that may be worth noting in the documentation.

@dhdaines
Copy link
Copy Markdown
Contributor

dhdaines commented May 13, 2026

A few minor changes to suggest, but nothing really crucial: serhiy-storchaka#25

@serhiy-storchaka serhiy-storchaka merged commit 9ad8a1b into python:3.14 May 15, 2026
48 checks passed
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented May 15, 2026

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the backport-e667d62-3.14 branch May 15, 2026 17:12
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 15, 2026

GH-149893 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 15, 2026
serhiy-storchaka added a commit that referenced this pull request May 15, 2026
@miss-islington @serhiy-storchaka @dhdaines
[3.13] gh-134837: Correct and improve base85 documentation for base64…
e90f3ba 
… module (GH-145843) (GH-149743) (GH-149893)

(cherry picked from commit e667d62)
(cherry picked from commit 9ad8a1b)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: David Huggins-Daines <dhd@ecolingui.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka @dhdaines