Fix stubs that are identical in different version/platform branches#15743
Open
JelleZijlstra wants to merge 1 commit intopython:mainfrom
Open
Fix stubs that are identical in different version/platform branches#15743JelleZijlstra wants to merge 1 commit intopython:mainfrom
JelleZijlstra wants to merge 1 commit intopython:mainfrom
Conversation
I wrote an experimental flake8-pyi check that alerts if multiple version/platform branches contain the same definition, because I noticed a few of my 3.15 PRs ended up with code like that. I'm not sure thsi should always be changed; in some complicated cases it's clearer to repeat the definition. But this PR changes some places where it seemed to be a win to do so. The most dubious is the asyncio one. BaseChildWatcher was the same in both branches; I added `@deprecated` in the branch where its child classes are deprecated. Even though BaseChildWatcher itself did not emit any deprecation warnings in 3.13, it was slated for removal, so it makes sense for type checkers to warn on any usage.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote an experimental flake8-pyi check that alerts if multiple
version/platform branches contain the same definition, because I
noticed a few of my 3.15 PRs ended up with code like that.
I'm not sure thsi should always be changed; in some complicated cases
it's clearer to repeat the definition. But this PR changes some places
where it seemed to be a win to do so.
The most dubious is the asyncio one. BaseChildWatcher was the same in
both branches; I added
@deprecatedin the branch where its childclasses are deprecated. Even though BaseChildWatcher itself did not
emit any deprecation warnings in 3.13, it was slated for removal,
so it makes sense for type checkers to warn on any usage.