Repository navigation
[BugFix] Let BatchSubSampler draw the last sub-trajectory window - #4709
Open
jackiectl2 wants to merge 1 commit into
Open
jackiectl2 wants to merge 1 commit into
jackiectl2 wants to merge 1 commit into
Conversation
Signed-off-by: Tianlang (Jackie) Chen <305351710+jackiectl2@users.noreply.github.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/4709
Note: Links to docs will display an error until the docs builds have been completed.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include traj_len - sub_traj_len as a possible start index so every complete sub-trajectory, including the terminal window, can be sampled.
Fixes #4708.
Validation
6 focused TestSubSampler tests passed; both window-coverage regressions fail without the fix. CPU torch 2.14.1 and TensorDict 0.14.2; the optional TorchRL C++ extension is not built. All changed-file pre-commit hooks passed under Python 3.11.
Full trainer suite and GPU training not run.