Repository navigation
Conversation
Mohit-Ak
marked this pull request as ready for review
October 24, 2026 21:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gmst()used6.2 * 10e-6for the cubic term of the IAU 1982 GMST polynomial, which is 6.2e-5 rather than 6.2e-6. Near J2000 you can't see the difference, but it grows with the cube of the time from J2000.This sets the coefficient to
6.2e-6. A newtest_gmst_far_from_j2000compares against the published polynomial at 2200-01-01. It fails before the change (off by about 3e-8 rad) and passes after.The coefficient change moved
TestGetObserverLook's zenith point from azimuth 180 to 270. The azimuth there is undefined and comes only from rounding noise.get_observer_lookalready says it returns 180 for an elevation of 90 degrees, so it now sets that value explicitly instead of relying on rounding. The existing fixture is unchanged.Full suite: 342 passed.
ruff checkis clean.Fixes #253