Repository navigation
Limit METimage reader dimension search to specific groups - #3487
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3487 +/- ##
=======================================
Coverage 96.45% 96.45%
=======================================
Files 474 474
Lines 61291 61302 +11
=======================================
+ Hits 59119 59130 +11
Misses 2172 2172
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4 tasks
This is an optimization and stops the entire file from being walked. Also update the L2 test fixtures to be more realistic.
djhoese
force-pushed
the
feat-metimage-smart-dims
branch
from
November 5, 2026 18:19
167006f to
9d376d5
Compare
djhoese
marked this pull request as ready for review
November 5, 2026 18:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is built on top of #3460 so only the most recent commit is actually involved here, but it is separate enough that I didn't want to include it in that PR. Once that PR is merged I'll rebase this one. This change would be too annoying to do in main and then update with the new PR.
The METimage reader does scan-based chunking. To do that it it used to look at all the dimensions in the file and then use only the sizes for the image arrays. This PR changes that to only use the typical group paths to find these dimensions. Claude confirmed that this should work for L1b and L2 files that I had available and @ameraner said L2 files should follow a similar structure.
AUTHORS.mdif not there already