Repository navigation
Test: settle allocation count before the hub check - #106
Merged
Merged
Conversation
Warm_capture_cycles_allocate_no_packet_objects counted 6008 bytes in the v1.3.0-beta.5 tag build and passed four other runs of the same commit. Like Signals.Allocated, a gen0 GC before reading the count keeps a background GC from adding bytes that nothing allocated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MixerCaptureBusTests.Warm_capture_cycles_allocate_no_packet_objects_and_repeated_stop_releases_every_rootcounted 6008 bytes in the v1.3.0-beta.5 tag build, although the same commit passed four other runs. It reads the thread's allocation count without the gen0 GC thatSignals.Allocateddoes first, so a background GC could add bytes nothing allocated. The test now does the same. Test-only change.