Repository navigation
Rename groundwork: updater and extension accept Akoustra - #110
Merged
Merged
Conversation
The app is to be renamed Akoustra, and the GitHub repository with it. After a rename GitHub redirects the API call but lists files and pages under the new name, so a version that accepts only qiyinxi/HomePodCast finds no update at all. Downloads and release pages now come from qiyinxi/HomePodCast or qiyinxi/Akoustra; nothing else changes.
2.0 is to rename the exe to Akoustra.exe, so an update from this version would leave no HomePodCast.exe for the helper to start again. The helper now waits for the app by its own exe name and, after msiexec, starts Akoustra.exe when the update put one into the install folder. UpdateTests also checks release files and pages under the repository's coming name (previous commit).
Both read the local status and check that the app is HomePodCast. They now accept Akoustra too, so they keep working if the renamed app ever reports its new name. The app itself still reports HomePodCast.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groundwork for the rename planned for 2.0 (Akoustra). Nothing visible changes in 1.4: the app, exe, folders and texts stay HomePodCast.
Tests: UpdateTests (helper picks the renamed exe, waits by exe name, PowerShell reads the new literals back; parse accepts the new repository and rejects lookalikes), ReleaseNotesTests, ReleaseFeedTests, VideoWindowTests, extension background.test.js. 2494 C# tests and 38 extension tests pass locally.