Skip to content

FENCE-3213: Remove trackVerifiedAutoFailover - #610

Merged
stevepopovich merged 4 commits into
masterfrom
stevenpopovich/fence-3213-remove-trackverifiedautofailover
Nov 19, 2026
Merged

stevepopovich merged 4 commits into
masterfrom
stevenpopovich/fence-3213-remove-trackverifiedautofailover

Conversation

@stevepopovich

@stevepopovich stevepopovich commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Failover to the secondary verified host is now always on. Customers cannot turn it off, so this PR removes the public trackVerifiedAutoFailover option. (FENCE-3213)

  • Remove trackVerifiedAutoFailover from the RadarInitializeOptions constructor and Builder.
  • Remove the saved setting from RadarSettings.
  • trackVerified() always retries on the secondary verified host when the primary host returns a non-Radar response.
  • RadarInitializeOptions has no JSON form on Android, so there is no JSON key to keep.
  • Add a 5.x to 5.x entry to MIGRATION.md.
  • Fix the existing ktlint violations in RadarInitializeOptions.kt and remove its baseline entries, because the line numbers moved.

Behavior change

  • Apps on 4.2.0 or later that kept the default (true): no change.
  • Apps that upgrade from 4.1.x or earlier (default false), and apps that set the option to false: trackVerified() can now send config requests to api-verified.radar.com. Apps that limit hosts or pin certificates must allow this host. MIGRATION.md says this.

Breaking change

This is breaking, but it removes an already deprecated option. This can be a minor version update.

  • Kotlin and Java apps that pass trackVerifiedAutoFailover no longer compile.
  • A saved false from an older SDK does not turn off failover.

Tests

  • test_Radar_trackVerified_failover_tracesBothConfigRequests now saves the old setting as false first, and failover still runs.
  • ./gradlew :sdk:ktlintCheck :sdk:lint :sdk:testDebugUnitTest :example:assembleDebug passes (581 unit tests).

iOS: radarlabs/radar-sdk-ios#808.

🤖 Generated with Claude Code

stevepopovich and others added 2 commits November 19, 2026 12:43
Failover to the secondary verified host is now always on. Customers
cannot turn it off, so the public option is removed.

- Remove the property and Builder setter from RadarInitializeOptions.
- Remove the saved setting from RadarSettings.
- trackVerified() always retries on the secondary host when the primary
  host returns a non-Radar response.
- A saved value from an older SDK does not turn off failover.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Radar.initialize() deletes the trackVerifiedAutoFailover value that
  older SDK versions saved.
- Merge the saved-setting failover test into the existing failover test.
- Add a 5.x to 6.0.0 entry to MIGRATION.md.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
stevepopovich and others added 2 commits November 19, 2026 15:08
Updated migration guide to reflect changes in versioning.
The SDK does not read the old track_verified_auto_failover value, so it
does not need to delete it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@stevepopovich
stevepopovich marked this pull request as ready for review November 19, 2026 20:15

@alanjcharles14 alanjcharles14 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think this looks fine to me. Lmk if you need to re-approve after getting the ci to work

@stevepopovich
stevepopovich merged commit 56fd9ad into master Nov 19, 2026
2 checks passed
@stevepopovich
stevepopovich deleted the stevenpopovich/fence-3213-remove-trackverifiedautofailover branch November 19, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants