Repository navigation
FENCE-3215: Record cross-platform framework and version on traces - #611
Draft
Jordan-Nelson wants to merge 1 commit into
Draft
Jordan-Nelson wants to merge 1 commit into
Jordan-Nelson wants to merge 1 commit into
Conversation
Trace resources only carried the native SDK version, so traces from cross-platform wrapper apps couldn't be told apart from native ones. Each stored span now records the framework (Native, or the wrapper's type) and the wrapper's version, matching the X-Radar-X-Platform-SDK-* headers. Batches only hold spans with the same values, and the upload sets radar.sdk.xplatform.type and radar.sdk.xplatform.version on the resource. Recording per span keeps spans from before a wrapper upgrade labeled with the version that recorded them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5 of 7 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trace resources carried
radar.sdk.version, which is always the native SDK version, so traces from cross-platform wrapper apps (React Native, Flutter, etc.) couldn't be told apart from native ones.RadarTraceManager.recordstores the framework (Native, or the wrapper's type) and the wrapper's version with each span. The values match theX-Radar-X-Platform-SDK-*headers.radar.sdk.xplatform.typeandradar.sdk.xplatform.versionon the OTLP resource. Native apps send no version.iOS: radarlabs/radar-sdk-ios#811
Linear ticket (Radar internal)
FENCE-3215
Type of change
Manual test steps
Covered by unit tests in
RadarTraceManagerTest:Nativewith no version.Checklist
./gradlew test)./gradlew :sdk:ktlintCheckand./gradlew :sdk:lintDebugpass locallyMIGRATION.mdentry and bumpedversioninsdk/build.gradle🤖 Generated with Claude Code