Inline destructured requires

packages/metro-transform-plugins/src/__tests__/__snapshots__/inline-requires-plugin-test.js.snap

@@ -7,6 +7,16 @@ var foo = require(\\"foo\\");
       ↓ ↓ ↓ ↓ ↓ ↓
 
 
+"
+`;
+
+exports[`memoizeCalls=false: inline-requires deletes unused destructured requires: deletes unused destructured requires 1`] = `
+"
+const {a} = require(\\"foo\\");
+
+      ↓ ↓ ↓ ↓ ↓ ↓
+
+
 "
 `;
 
@@ -91,6 +101,25 @@ function test() {
 "
 `;
 
+exports[`memoizeCalls=false: inline-requires ignores destructured properties that are re-assigned: ignores destructured properties that are re-assigned 1`] = `
+"
+var X = require(\\"X\\");
+const {a} = require(\\"X\\");
+X.a = function() {
+  a();
+};
+
+      ↓ ↓ ↓ ↓ ↓ ↓
+
+const {
+  a
+} = require(\\"X\\");
+require(\\"X\\").a = function () {
+  a();
+};
+"
+`;
+
 exports[`memoizeCalls=false: inline-requires ignores require properties (as identifiers) that are re-assigned: ignores require properties (as identifiers) that are re-assigned 1`] = `
 "
 var X = require(\\"X\\");
@@ -137,6 +166,46 @@ require(\\"foo\\").method();
 "
 `;
 
+exports[`memoizeCalls=false: inline-requires inlines destructured requires referenced across scopes: inlines destructured requires referenced across scopes 1`] = `
+"
+const {a, b} = require(\\"foo\\");
+function f() {
+  return a() + b();
+}
+function g() {
+  if (b()) {
+    a();
+  }
+}
+
+      ↓ ↓ ↓ ↓ ↓ ↓
+
+function f() {
+  return require(\\"foo\\").a() + require(\\"foo\\").b();
+}
+function g() {
+  if (require(\\"foo\\").b()) {
+    require(\\"foo\\").a();
+  }
+}
+"
+`;
+
+exports[`memoizeCalls=false: inline-requires inlines destructured requires: inlines destructured requires 1`] = `
+"
+const {a, b: c, \\"d-e\\": de} = require(\\"foo\\");
+a();
+c.x();
+de();
+
+      ↓ ↓ ↓ ↓ ↓ ↓
+
+require(\\"foo\\").a();
+require(\\"foo\\").b.x();
+require(\\"foo\\")[\\"d-e\\"]();
+"
+`;
+
 exports[`memoizeCalls=false: inline-requires inlines functions provided via \`inlineableCalls\`: inlines functions provided via \`inlineableCalls\` 1`] = `
 "
 const inlinedCustom = customStuff(\\"foo\\");
@@ -244,6 +313,16 @@ var foo = require(\\"foo\\");
       ↓ ↓ ↓ ↓ ↓ ↓
 
 
+"
+`;
+
+exports[`memoizeCalls=true: inline-requires deletes unused destructured requires: deletes unused destructured requires 1`] = `
+"
+const {a} = require(\\"foo\\");
+
+      ↓ ↓ ↓ ↓ ↓ ↓
+
+
 "
 `;
 
@@ -331,6 +410,26 @@ function test() {
 "
 `;
 
+exports[`memoizeCalls=true: inline-requires ignores destructured properties that are re-assigned: ignores destructured properties that are re-assigned 1`] = `
+"
+var X = require(\\"X\\");
+const {a} = require(\\"X\\");
+X.a = function() {
+  a();
+};
+
+      ↓ ↓ ↓ ↓ ↓ ↓
+
+var X;
+const {
+  a
+} = require(\\"X\\");
+(X || (X = require(\\"X\\"))).a = function () {
+  a();
+};
+"
+`;
+
 exports[`memoizeCalls=true: inline-requires ignores require properties (as identifiers) that are re-assigned: ignores require properties (as identifiers) that are re-assigned 1`] = `
 "
 var X = require(\\"X\\");
@@ -380,6 +479,48 @@ var baz = 4;
 "
 `;
 
+exports[`memoizeCalls=true: inline-requires inlines destructured requires referenced across scopes: inlines destructured requires referenced across scopes 1`] = `
+"
+const {a, b} = require(\\"foo\\");
+function f() {
+  return a() + b();
+}
+function g() {
+  if (b()) {
+    a();
+  }
+}
+
+      ↓ ↓ ↓ ↓ ↓ ↓
+
+var _foo;
+function f() {
+  return (_foo || (_foo = require(\\"foo\\"))).a() + _foo.b();
+}
+function g() {
+  if ((_foo || (_foo = require(\\"foo\\"))).b()) {
+    (_foo || (_foo = require(\\"foo\\"))).a();
+  }
+}
+"
+`;
+
+exports[`memoizeCalls=true: inline-requires inlines destructured requires: inlines destructured requires 1`] = `
+"
+const {a, b: c, \\"d-e\\": de} = require(\\"foo\\");
+a();
+c.x();
+de();
+
+      ↓ ↓ ↓ ↓ ↓ ↓
+
+var _foo;
+(_foo || (_foo = require(\\"foo\\"))).a();
+_foo.b.x();
+_foo[\\"d-e\\"]();
+"
+`;
+
 exports[`memoizeCalls=true: inline-requires inlines functions provided via \`inlineableCalls\`: inlines functions provided via \`inlineableCalls\` 1`] = `
 "
 const inlinedCustom = customStuff(\\"foo\\");

packages/metro-transform-plugins/src/__tests__/inline-requires-plugin-test.js

@@ -238,6 +238,97 @@ const TEST_CASES: TestCases = {
     code: ['const a = require("Foo", "Bar", 47);', '', 'a();'].join('\n'),
     snapshot: true,
   },
+
+  'inlines destructured requires': {
+    code: [
+      'const {a, b: c, "d-e": de} = require("foo");',
+      'a();',
+      'c.x();',
+      'de();',
+    ].join('\n'),
+    snapshot: true,
+  },
+
+  'inlines destructured requires referenced across scopes': {
+    code: [
+      'const {a, b} = require("foo");',
+      'function f() {',
+      '  return a() + b();',
+      '}',
+      'function g() {',
+      '  if (b()) {',
+      '    a();',
+      '  }',
+      '}',
+    ].join('\n'),
+    snapshot: true,
+  },
+
+  'deletes unused destructured requires': {
+    code: ['const {a} = require("foo");'].join('\n'),
+    snapshot: true,
+  },
+
+  'ignores destructured requires with defaults': {
+    code: ['const {', '  a = 1', '} = require("foo");', 'a();'].join('\n'),
+    snapshot: false,
+  },
+
+  'ignores destructured requires with rest elements': {
+    code: [
+      'const {',
+      '  a,',
+      '  ...rest',
+      '} = require("foo");',
+      'a(rest);',
+    ].join('\n'),
+    snapshot: false,
+  },
+
+  'ignores nested destructured requires': {
+    code: [
+      'const {',
+      '  a: {',
+      '    b',
+      '  }',
+      '} = require("foo");',
+      'b();',
+    ].join('\n'),
+    snapshot: false,
+  },
+
+  'ignores destructured requires with computed keys': {
+    code: ['const {', '  [key]: a', '} = require("foo");', 'a();'].join('\n'),
+    snapshot: false,
+  },
+
+  'ignores destructured requires that are re-assigned': {
+    code: [
+      'let {',
+      '  a,',
+      '  b',
+      '} = require("foo");',
+      'b = 1;',
+      'a(b);',
+    ].join('\n'),
+    snapshot: false,
+  },
+
+  'ignores destructured properties that are re-assigned': {
+    code: [
+      'var X = require("X");',
+      'const {a} = require("X");',
+      'X.a = function() {',
+      '  a();',
+      '};',
+    ].join('\n'),
+    snapshot: true,
+  },
+
+  'ignores destructured requires in `ignoredRequires`': {
+    code: ['const {', '  a', '} = require("CommonFoo");', 'a();'].join('\n'),
+    snapshot: false,
+  },
 };
 
 describe.each([true, false])('memoizeCalls=%s:', memoizeCalls => {