Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
robhogan
changed the title
Since #1892, Metro's transformer gets an asset's URL path as a sixth argument, and `getAssets` computes it separately. Wrappers that forward only the five they declare (eg NativeWind's `react-native-css-interop`) get the old path, so release builds put monorepo assets where the app doesn't look: ``` bundle: /assets/../shared/img getAssets: /assets/[metro-watchFolders]/1/shared/img ``` - Metro's transformer reports the URL path it used, as `unstable_assetUrlPath` on asset outputs (a temporary migration helper). - `getAssets` uses it, or the project-relative path (as in 0.87.1) when a transformer doesn't report one. Also needed in the 0.84.7 picks (#2070). Changelog: Internal Test plan: - New integration test with Metro's transformer and a wrapper. The wrapper case fails without this change.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #1892, Metro's transformer gets an asset's URL path as a sixth argument, and
getAssetscomputes it separately. Wrappers that forward only the five they declare (eg NativeWind'sreact-native-css-interop) get the old path, so release builds put monorepo assets where the app doesn't look:unstable_assetUrlPathon asset outputs (a temporary migration helper).getAssetsuses it, or the project-relative path (as in 0.87.1) when a transformer doesn't report one.Also needed in the 0.84.7 picks (#2070).
Changelog: Internal
Test plan: