Skip to content

Defer cloning unchanged Yoga children until layout #59302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hryhoriiK97 wants to merge 4 commits into
base: main
Choose a base branch
from
+719 −112
Open

Defer cloning unchanged Yoga children until layout #59302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c100e9
Defer cloning unchanged Yoga children until layout
hryhoriiK97 Oct 21, 2026
e312cc6
Clone a shared child before writing its layout, and test more layouts
hryhoriiK97 Oct 21, 2026
5a067b2
Merge main into yoga-defer-child-cloning
hryhoriiK97 Oct 21, 2026
bfaa637
Merge main into yoga-defer-child-cloning
hryhoriiK97 Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
468 changes: 468 additions & 0 deletions ...ages/react-native/Libraries/Components/View/__tests__/View-deferYogaChildCloning-itest.js
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 7 additions & 1 deletion ...Android/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlags.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<b5f4608f47743d0e2e9b1db3db551227>>
* @generated SignedSource<<2abf1e8d28c8f625e2a51cf2e48c1c90>>
*/

/**
Expand Down Expand Up @@ -60,6 +60,12 @@ public object ReactNativeFeatureFlags {
@JvmStatic
public fun deferTextInputTruncationIOS(): Boolean = accessor.deferTextInputTruncationIOS()

/**
* When a node gets a new list of children, the children that a previous revision of the node still owns stay shared with that revision instead of being cloned right away. Yoga clones them if it lays the node out.
*/
@JvmStatic
public fun deferYogaChildCloningUntilLayout(): Boolean = accessor.deferYogaChildCloningUntilLayout()

/**
* Dispatch view commands in mount item order.
*/
Expand Down
12 changes: 11 additions & 1 deletion .../main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxAccessor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<d2d170d333194ce2f2a4f1d93321ac6d>>
* @generated SignedSource<<f41241abd53c60b3203e664b426db32b>>
*/

/**
Expand All @@ -25,6 +25,7 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
private var cxxNativeAnimatedEnabledCache: Boolean? = null
private var defaultTextToOverflowHiddenCache: Boolean? = null
private var deferTextInputTruncationIOSCache: Boolean? = null
private var deferYogaChildCloningUntilLayoutCache: Boolean? = null
private var disableEarlyViewCommandExecutionCache: Boolean? = null
private var disableIdleEventDispatchFrameCallbackRearmAndroidCache: Boolean? = null
private var disableIdleMountItemFrameCallbackRearmAndroidCache: Boolean? = null
Expand Down Expand Up @@ -162,6 +163,15 @@ internal class ReactNativeFeatureFlagsCxxAccessor : ReactNativeFeatureFlagsAcces
return cached
}

override fun deferYogaChildCloningUntilLayout(): Boolean {
var cached = deferYogaChildCloningUntilLayoutCache
if (cached == null) {
cached = ReactNativeFeatureFlagsCxxInterop.deferYogaChildCloningUntilLayout()
deferYogaChildCloningUntilLayoutCache = cached
}
return cached
}

override fun disableEarlyViewCommandExecution(): Boolean {
var cached = disableEarlyViewCommandExecutionCache
if (cached == null) {
Expand Down
4 changes: 3 additions & 1 deletion ...c/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsCxxInterop.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<ec3e384af62c0e672da53b57354bca62>>
* @generated SignedSource<<8c3be9a45fa1118c418be24467580edf>>
*/

/**
Expand Down Expand Up @@ -38,6 +38,8 @@ public object ReactNativeFeatureFlagsCxxInterop {

@DoNotStrip @JvmStatic public external fun deferTextInputTruncationIOS(): Boolean

@DoNotStrip @JvmStatic public external fun deferYogaChildCloningUntilLayout(): Boolean

@DoNotStrip @JvmStatic public external fun disableEarlyViewCommandExecution(): Boolean

@DoNotStrip @JvmStatic public external fun disableIdleEventDispatchFrameCallbackRearmAndroid(): Boolean
Expand Down
4 changes: 3 additions & 1 deletion ...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<cd6aa804d1c10b93775adf83419368e3>>
* @generated SignedSource<<b194cf90d38e2d2b538d5be81c24af55>>
*/

/**
Expand Down Expand Up @@ -33,6 +33,8 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi

override fun deferTextInputTruncationIOS(): Boolean = false

override fun deferYogaChildCloningUntilLayout(): Boolean = false

override fun disableEarlyViewCommandExecution(): Boolean = false

override fun disableIdleEventDispatchFrameCallbackRearmAndroid(): Boolean = false
Expand Down
13 changes: 12 additions & 1 deletion ...ain/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsLocalAccessor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<c36b0b2d7173aa78b7cb175658fc89d2>>
* @generated SignedSource<<ad04b2eec324da0239508ee8164df70b>>
*/

/**
Expand All @@ -29,6 +29,7 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
private var cxxNativeAnimatedEnabledCache: Boolean? = null
private var defaultTextToOverflowHiddenCache: Boolean? = null
private var deferTextInputTruncationIOSCache: Boolean? = null
private var deferYogaChildCloningUntilLayoutCache: Boolean? = null
private var disableEarlyViewCommandExecutionCache: Boolean? = null
private var disableIdleEventDispatchFrameCallbackRearmAndroidCache: Boolean? = null
private var disableIdleMountItemFrameCallbackRearmAndroidCache: Boolean? = null
Expand Down Expand Up @@ -171,6 +172,16 @@ internal class ReactNativeFeatureFlagsLocalAccessor : ReactNativeFeatureFlagsAcc
return cached
}

override fun deferYogaChildCloningUntilLayout(): Boolean {
var cached = deferYogaChildCloningUntilLayoutCache
if (cached == null) {
cached = currentProvider.deferYogaChildCloningUntilLayout()
accessedFeatureFlags.add("deferYogaChildCloningUntilLayout")
deferYogaChildCloningUntilLayoutCache = cached
}
return cached
}

override fun disableEarlyViewCommandExecution(): Boolean {
var cached = disableEarlyViewCommandExecutionCache
if (cached == null) {
Expand Down
4 changes: 3 additions & 1 deletion ...src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<c5e9b41b76c5580c0a4ba848af4e36a5>>
* @generated SignedSource<<e71427d93782550acd6fc378661487fa>>
*/

/**
Expand Down Expand Up @@ -33,6 +33,8 @@ public interface ReactNativeFeatureFlagsProvider {

@DoNotStrip public fun deferTextInputTruncationIOS(): Boolean

@DoNotStrip public fun deferYogaChildCloningUntilLayout(): Boolean

@DoNotStrip public fun disableEarlyViewCommandExecution(): Boolean

@DoNotStrip public fun disableIdleEventDispatchFrameCallbackRearmAndroid(): Boolean
Expand Down
16 changes: 15 additions & 1 deletion ...ative/ReactAndroid/src/main/jni/react/featureflags/JReactNativeFeatureFlagsCxxInterop.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<1ab2eec7b9c5bdd181ec5fbfd37149ab>>
* @generated SignedSource<<f831fb06cb03ec0e45fa6a9e433e1c89>>
*/

/**
Expand Down Expand Up @@ -69,6 +69,12 @@ class ReactNativeFeatureFlagsJavaProvider
return method(javaProvider_);
}

bool deferYogaChildCloningUntilLayout() override {
static const auto method =
getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("deferYogaChildCloningUntilLayout");
return method(javaProvider_);
}

bool disableEarlyViewCommandExecution() override {
static const auto method =
getReactNativeFeatureFlagsProviderJavaClass()->getMethod<jboolean()>("disableEarlyViewCommandExecution");
Expand Down Expand Up @@ -644,6 +650,11 @@ bool JReactNativeFeatureFlagsCxxInterop::deferTextInputTruncationIOS(
return ReactNativeFeatureFlags::deferTextInputTruncationIOS();
}

bool JReactNativeFeatureFlagsCxxInterop::deferYogaChildCloningUntilLayout(
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
return ReactNativeFeatureFlags::deferYogaChildCloningUntilLayout();
}

bool JReactNativeFeatureFlagsCxxInterop::disableEarlyViewCommandExecution(
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop> /*unused*/) {
return ReactNativeFeatureFlags::disableEarlyViewCommandExecution();
Expand Down Expand Up @@ -1145,6 +1156,9 @@ void JReactNativeFeatureFlagsCxxInterop::registerNatives() {
makeNativeMethod(
"deferTextInputTruncationIOS",
JReactNativeFeatureFlagsCxxInterop::deferTextInputTruncationIOS),
makeNativeMethod(
"deferYogaChildCloningUntilLayout",
JReactNativeFeatureFlagsCxxInterop::deferYogaChildCloningUntilLayout),
makeNativeMethod(
"disableEarlyViewCommandExecution",
JReactNativeFeatureFlagsCxxInterop::disableEarlyViewCommandExecution),
Expand Down
5 changes: 4 additions & 1 deletion ...-native/ReactAndroid/src/main/jni/react/featureflags/JReactNativeFeatureFlagsCxxInterop.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<2c8f9205f1de55591ede3845ba2fa877>>
* @generated SignedSource<<5e769fa7ac77deacc90e2ae22182b931>>
*/

/**
Expand Down Expand Up @@ -45,6 +45,9 @@ class JReactNativeFeatureFlagsCxxInterop
static bool deferTextInputTruncationIOS(
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

static bool deferYogaChildCloningUntilLayout(
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

static bool disableEarlyViewCommandExecution(
facebook::jni::alias_ref<JReactNativeFeatureFlagsCxxInterop>);

Expand Down
6 changes: 5 additions & 1 deletion packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlags.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<7542508e6a3b0dd942557748186527b3>>
* @generated SignedSource<<8d8245d58026b35edf8a6d2c9a3ee95b>>
*/

/**
Expand Down Expand Up @@ -46,6 +46,10 @@ bool ReactNativeFeatureFlags::deferTextInputTruncationIOS() {
return getAccessor().deferTextInputTruncationIOS();
}

bool ReactNativeFeatureFlags::deferYogaChildCloningUntilLayout() {
return getAccessor().deferYogaChildCloningUntilLayout();
}

bool ReactNativeFeatureFlags::disableEarlyViewCommandExecution() {
return getAccessor().disableEarlyViewCommandExecution();
}
Expand Down
7 changes: 6 additions & 1 deletion packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlags.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<e3c3ccaf63fcdcf48c6f02f793f77b65>>
* @generated SignedSource<<dc1037c6be4656b3eea974b7b20018b0>>
*/

/**
Expand Down Expand Up @@ -66,6 +66,11 @@ class ReactNativeFeatureFlags {
*/
RN_EXPORT static bool deferTextInputTruncationIOS();

/**
* When a node gets a new list of children, the children that a previous revision of the node still owns stay shared with that revision instead of being cloned right away. Yoga clones them if it lays the node out.
*/
RN_EXPORT static bool deferYogaChildCloningUntilLayout();

/**
* Dispatch view commands in mount item order.
*/
Expand Down
Loading
Loading