Skip to content

Prune dead RCTBridge private declarations (#59319) - #59319

Open
christophpurrer wants to merge 2 commits into
react:mainfrom
christophpurrer:export-D126592134
Open

christophpurrer wants to merge 2 commits into
react:mainfrom
christophpurrer:export-D126592134

Conversation

@christophpurrer

@christophpurrer christophpurrer commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary:

Remove bridge declarations with zero callers: profiler flow state,
test-only setup, module data lookup, profiling toggles, and the
unimplemented TurboModule category. The proxy keeps its shims, so
runtime behavior is unchanged.

Changelog:
[Internal]

Reviewed By: shwanton

Differential Revision: D126592134

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2026
@meta-codesync

meta-codesync Bot commented Oct 21, 2026

Copy link
Copy Markdown

@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126592134.

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Oct 21, 2026
Summary:
Pull Request resolved: react#59319

Remove bridge declarations with zero callers: profiler flow state,
test-only setup, module data lookup, profiling toggles, and the
unimplemented TurboModule category. The proxy keeps its shims, so
runtime behavior is unchanged.

Changelog:
[Internal]

Differential Revision: D126592134
@meta-codesync meta-codesync Bot changed the title Prune dead RCTBridge private declarations Prune dead RCTBridge private declarations (#59319) Oct 21, 2026
christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Oct 22, 2026
Summary:
Pull Request resolved: react#59319

Remove bridge declarations with zero callers: profiler flow state,
test-only setup, module data lookup, profiling toggles, and the
unimplemented TurboModule category. The proxy keeps its shims, so
runtime behavior is unchanged.

Changelog:
[Internal]

Reviewed By: shwanton

Differential Revision: D126592134
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Visual regression

1 visual difference(s) at 7f6b3dab67cf. Visual differences need maintainer approval. Review the report, then apply visual-change-approved.

android: no capture

ios button/two-buttons-flexbox/default: Changed, 280048 px (11.234%)

diff

Expected and Captured
Expected Captured
expected captured

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Oct 23, 2026
Summary:

Remove bridge declarations with zero callers: profiler flow state,
test-only setup, module data lookup, profiling toggles, and the
unimplemented TurboModule category. The proxy keeps its shims, so
runtime behavior is unchanged.

Changelog:
[Internal]

Reviewed By: shwanton

Differential Revision: D126592134
Summary:

RCTProfile hooked bridge modules for systrace capture, driven only by the deleted legacy bridge. With all call sites migrated or removed, delete the header, implementation, trampolines, and remaining hooks in the display link, module methods, performance logger, and downstream systrace callers.

Changelog:
[iOS][Removed] - Remove deprecated RCTProfile systrace API

Reviewed By: shwanton

Differential Revision: D126581734
Summary:

Remove bridge declarations with zero callers: profiler flow state,
test-only setup, module data lookup, profiling toggles, and the
unimplemented TurboModule category. The proxy keeps its shims, so
runtime behavior is unchanged.

Changelog:
[Internal]

Reviewed By: shwanton

Differential Revision: D126592134

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant