Repository navigation
fix(Text): map aria-live to accessibilityLiveRegion - #59330
Open
faciledictu wants to merge 3 commits into
Open
faciledictu wants to merge 3 commits into
faciledictu wants to merge 3 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Textacceptsaria-livein its types (TextPropsincludesAccessibilityProps), butText.jsdoes not map it the wayView.jsdoes: the prop reaches the native side asaria-live, which is not read there, so aTextwitharia-livenever announces its changes.accessibilityLiveRegionon the sameTextworks.This maps
aria-livetoaccessibilityLiveRegioninText, the same wayViewdoes (offbecomesnone).Related: #59329
Changelog:
[ANDROID] [FIXED] -
aria-liveonTextnow setsaccessibilityLiveRegionTest Plan:
Added a Fantom test:
<Text aria-live="polite">renders withaccessibilityLiveRegion="polite".On a device (Samsung SM-A276B, Android 16, TalkBack on, React Native 0.88.0, Expo SDK 58 development build), a counter in
<Text aria-live="polite">is not announced when it changes; the same counter in<Text accessibilityLiveRegion="polite">is announced on every change. With this changearia-liveproduces the same native prop, which the Fantom test checks.