Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126907218. |
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 23, 2026
Summary: Pull Request resolved: react#59391 `Pressable`, `TouchableHighlight`, `TouchableOpacity` and `TouchableNativeFeedback` delegate accessibility aliases to `View` instead of reconstructing optional accessibility props. Forward unconsumed Touchable props through `restProps`, preserving touch-specific defaults and existing child props. Use the resolved Pressability disabled state so accessibility and press handling agree, including inherited `aria-disabled` and `accessibilityState.disabled` values. Keep compatibility mappings for non-View native-feedback children. Changelog: [General][Fixed] - Forward accessibility aliases and View props consistently through Pressable and Touchable components. Differential Revision: D126907218
meta-codesync
Bot
changed the title
javache
force-pushed
the
export-D126907218
branch
from
October 23, 2026 10:04
ba82eaf to
8f40e6b
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 23, 2026
Summary: Pull Request resolved: react#59391 `Pressable` and View-backed Touchables delegate accessibility normalisation to `View` and forward unconsumed props with `restProps`, without synthesising noisy default props. Preserve the existing press and focus rules, and let Jest exercise the same normalisation by mocking only the native View boundary. Update the dependent snapshots and native-boundary assertions accordingly. Changelog: [General][Fixed] - Forward accessibility aliases and View props consistently through Pressable and Touchable components. Differential Revision: D126907218
javache
force-pushed
the
export-D126907218
branch
from
October 23, 2026 11:05
8f40e6b to
f53e1e0
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 23, 2026
Summary: Pull Request resolved: react#59391 `Pressable` and View-backed Touchables delegate accessibility normalisation to `View` and forward unconsumed props with `restProps`, without synthesising noisy default props. Preserve the existing press and focus rules, and let Jest exercise the same normalisation by mocking only the native View boundary. Update the dependent snapshots and native-boundary assertions accordingly. Changelog: [General][Fixed] - Forward accessibility aliases and View props consistently through Pressable and Touchable components. Differential Revision: D126907218
javache
force-pushed
the
export-D126907218
branch
from
October 23, 2026 11:19
f53e1e0 to
da8caed
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 23, 2026
Summary: Pull Request resolved: react#59391 `Pressable` and View-backed Touchables delegate accessibility normalisation to `View` and forward unconsumed props with `restProps`, without synthesising noisy default props. Preserve the existing press and focus rules, and let Jest exercise the same normalisation by mocking only the native View boundary. Update the dependent snapshots and native-boundary assertions accordingly. Changelog: [General][Fixed] - Forward accessibility aliases and View props consistently through Pressable and Touchable components. Differential Revision: D126907218
javache
force-pushed
the
export-D126907218
branch
from
October 23, 2026 11:36
da8caed to
bdde872
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 23, 2026
) Summary: Pull Request resolved: react#59391 Forward unconsumed view props to the native-feedback child and let `View` normalise accessibility aliases. Preserve child styling and retain legacy alias resolution for non-View children without synthesising empty state or value props. Changelog: [General][Fixed] - Forward accessibility props consistently in TouchableNativeFeedback while preserving child styles. Differential Revision: D126907218
javache
force-pushed
the
export-D126907218
branch
from
October 23, 2026 12:23
bdde872 to
f9819c7
Compare
meta-codesync
Bot
changed the title
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 23, 2026
) Summary: Pull Request resolved: react#59391 Forward unconsumed view props to the native-feedback child and let `View` normalise accessibility aliases. Preserve child styling and retain legacy alias resolution for non-View children without synthesising empty state or value props. Changelog: [General][Fixed] - Forward accessibility props consistently in TouchableNativeFeedback while preserving child styles. Differential Revision: D126907218
javache
force-pushed
the
export-D126907218
branch
from
October 23, 2026 12:28
f9819c7 to
d8e98ac
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 23, 2026
) Summary: Pull Request resolved: react#59391 Forward unconsumed view props to the native-feedback child and let `View` normalise accessibility aliases. Preserve child styling and retain legacy alias resolution for non-View children without synthesising empty state or value props. Changelog: [General][Fixed] - Forward accessibility props consistently in TouchableNativeFeedback while preserving child styles. Differential Revision: D126907218
javache
force-pushed
the
export-D126907218
branch
from
October 23, 2026 13:03
d8e98ac to
0e60b70
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 23, 2026
) Summary: Pull Request resolved: react#59391 Forward unconsumed view props to the native-feedback child and let `View` normalise accessibility aliases. Preserve child styling and retain legacy alias resolution for non-View children without synthesising empty state or value props. Changelog: [General][Fixed] - Forward accessibility props consistently in TouchableNativeFeedback while preserving child styles. Differential Revision: D126907218
javache
force-pushed
the
export-D126907218
branch
from
October 23, 2026 13:38
0e60b70 to
930a1b2
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 23, 2026
) Summary: Pull Request resolved: react#59391 Forward unconsumed view props to the native-feedback child and let `View` normalise accessibility aliases. Preserve child styling and retain legacy alias resolution for non-View children without synthesising empty state or value props. Changelog: [General][Fixed] - Forward accessibility props consistently in TouchableNativeFeedback while preserving child styles. Differential Revision: D126907218
javache
force-pushed
the
export-D126907218
branch
from
October 23, 2026 13:53
930a1b2 to
8f8be56
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 23, 2026
) Summary: Pull Request resolved: react#59391 Forward unconsumed view props to the native-feedback child and let `View` normalise accessibility aliases. Preserve child styling and retain legacy alias resolution for non-View children without synthesising empty state or value props. Changelog: [General][Fixed] - Forward accessibility props consistently in TouchableNativeFeedback while preserving child styles. Differential Revision: D126907218
javache
force-pushed
the
export-D126907218
branch
from
October 23, 2026 14:50
8f8be56 to
9a8dca2
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 23, 2026
) Summary: Pull Request resolved: react#59391 Forward unconsumed view props to the native-feedback child and let `View` normalise accessibility aliases. Preserve child styling and retain legacy alias resolution for non-View children without synthesising empty state or value props. Changelog: [General][Fixed] - Forward accessibility props consistently in TouchableNativeFeedback while preserving child styles. Differential Revision: D126907218
javache
force-pushed
the
export-D126907218
branch
from
October 23, 2026 16:26
9a8dca2 to
156d5fa
Compare
) Summary: Pull Request resolved: react#59399 Only construct accessibility state in Pressable and Touchable wrappers when a state object, ARIA state or disabled value was supplied. Preserve explicit empty state objects, false and mixed values, and custom-child state when wrapper inputs are absent. Keep View normalisation unchanged. Changelog: [General][Fixed] - Avoid manufacturing empty accessibility state objects in pressable wrappers. Differential Revision: D127141096
Summary: Pull Request resolved: react#59398 Mock only the native View boundary so Jest exercises the real `View` prop normalisation. Preserve native ref methods and migrate dependent tests to observe native host state rather than implementation details. Changelog: [Internal] Differential Revision: D127141935
Summary: Forward accessibility props to `View` rather than building duplicate accessibility state and value objects. Preserve explicit disabled precedence and existing press behaviour. Changelog: [General][Fixed] - Avoid synthesising empty accessibility props in Pressable. Differential Revision: D127143129
Summary: Pull Request resolved: react#59402 Let `View` normalise accessibility aliases and forward remaining view props, retaining TouchableHighlight defaults, press behaviour and underlay styling. Changelog: [General][Fixed] - Forward view and accessibility props consistently in TouchableHighlight. Differential Revision: D127143599
Summary: Forward remaining view props and delegate accessibility aliases to `View` while retaining opacity animation, press behaviour and disabled precedence. Changelog: [General][Fixed] - Forward view and accessibility props consistently in TouchableOpacity. Differential Revision: D127143976
) Summary: Pull Request resolved: react#59391 Forward unconsumed view props to the native-feedback child and let `View` normalise accessibility aliases. Preserve child styling and retain legacy alias resolution for non-View children without synthesising empty state or value props. Changelog: [General][Fixed] - Forward accessibility props consistently in TouchableNativeFeedback while preserving child styles. Differential Revision: D126907218
javache
force-pushed
the
export-D126907218
branch
from
October 23, 2026 16:46
156d5fa to
098c01b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Forward unconsumed view props to the native-feedback child and let
Viewnormalise accessibility aliases. Preserve child styling and retain legacy alias resolution for non-View children without synthesising empty state or value props.Changelog:
[General][Fixed] - Forward accessibility props consistently in TouchableNativeFeedback while preserving child styles.
Differential Revision: D126907218