Repository navigation
Delete dead RCTBridge public API and skipped logging tests (#59429) - #59429
Open
christophpurrer wants to merge 3 commits into
Open
christophpurrer wants to merge 3 commits into
christophpurrer wants to merge 3 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127265582. |
christophpurrer
force-pushed
the
export-D127265582
branch
from
October 23, 2026 23:14
d0802f7 to
cba4288
Compare
Visual regressionNo visual differences at |
meta-codesync
Bot
changed the title
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 24, 2026
Summary: Remove `RCTBridge` declarations with zero callers: `enqueueJSCall`, module lookup, `delegate`, `moduleClasses`, reload, and batch APIs, plus their stub implementations. Keep `bundleURL`, still read by Expo Dev Menu, and the TurboModule-registry hooks the proxy forwards through, all marked deprecated. Delete skipped `RCTLoggingTests`, the only `enqueueJSCall` caller. Changelog: [iOS][Removed] - Remove unused `RCTBridge` reload, module-lookup, and JS-callback APIs [iOS][Deprecated] - Deprecate `RCTBridge.bundleURL`, `setRCTTurboModuleRegistry:`, and `bridgeModuleDecorator` Differential Revision: D127265582
christophpurrer
force-pushed
the
export-D127265582
branch
from
October 24, 2026 03:09
cba4288 to
0db73f4
Compare
Summary: `RCTModuleData` is never instantiated and its implementation is a stub: initializers return `self`, and `gatherConstants`/`invalidate` are no-ops. Delete the header and implementation with the unused `RCTBridgeModuleProvider` typedef and `RCTModuleDataCallInvokerProvider` protocol, plus the buck header-map entry and all import sites. Changelog: [iOS][Removed] - Remove deprecated `RCTModuleData` class and its call-invoker provider protocol Differential Revision: D127228438
) Summary: `+[RCTBridge currentBridge]` always returns nil and `+[RCTBridge setCurrentBridge:]` is a no-op: with the legacy bridge gone, nothing ever sets a current bridge, so the getter can only return nil. Remove the last two internal call sites in `RCTInstance` (iOS and macOS) along with their now-dead `RCTBridge+Private.h` imports. Keep both declarations, now marked deprecated, so existing external Swift callers (`RCTBridge.current()`) keep compiling and linking; they will only ever observe nil, the sole value this API can produce. Changelog: [Internal] Differential Revision: D127265579
Summary: Remove `RCTBridge` declarations with zero callers: `enqueueJSCall`, module lookup, `delegate`, `moduleClasses`, reload, and batch APIs, plus their stub implementations. Keep `bundleURL`, still read by Expo Dev Menu, and the TurboModule-registry hooks the proxy forwards through, all marked deprecated. Delete skipped `RCTLoggingTests`, the only `enqueueJSCall` caller. Changelog: [iOS][Removed] - Remove unused `RCTBridge` reload, module-lookup, and JS-callback APIs [iOS][Deprecated] - Deprecate `RCTBridge.bundleURL`, `setRCTTurboModuleRegistry:`, and `bridgeModuleDecorator` Differential Revision: D127265582
christophpurrer
force-pushed
the
export-D127265582
branch
from
October 24, 2026 03:21
0db73f4 to
981a3d3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Remove
RCTBridgedeclarations with zero callers:enqueueJSCall, module lookup,delegate,moduleClasses, reload, and batch APIs, plus their stub implementations. KeepbundleURL, still read by Expo Dev Menu, and the TurboModule-registry hooks the proxy forwards through, all marked deprecated. Delete skippedRCTLoggingTests, the onlyenqueueJSCallcaller.Changelog:
[iOS][Removed] - Remove unused
RCTBridgereload, module-lookup, and JS-callback APIs[iOS][Deprecated] - Deprecate
RCTBridge.bundleURL,setRCTTurboModuleRegistry:, andbridgeModuleDecoratorDifferential Revision: D127265582