Repository navigation
Conversation
Backport the already-landed background attribute fix from react#59207. Omitting the default clear attribute also restores the Japanese IME composition underline in the isolated native input comparison. (cherry picked from commit 0bd3326)
|
Hi @riottt! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary:
Backport #59207 to
0.88-stableand add five regression tests. The production hunk is unchanged from the upstream implementation by Gregory Moskaliuk (@hryhoriiK97).The default clear
NSBackgroundColorAttributeNamesuppresses the Japanese IME composition underline even while the native marked range remains active. Omitting that attribute restores the underline. Visible backgrounds and foreground/background opacity remain intact. Input delegates and selection/synchronization logic are unchanged.Related to #48497 and the underline portion of #56082.
Changelog:
[IOS] [FIXED] - Avoid a default transparent text background that can suppress the Japanese IME composition underline.
Test Plan:
RNTester and React Native Core built from source, with
RCT_USE_PREBUILT_RNCORE=0. Xcode 27.0, iPhone 17 simulator / iOS 27.0, Apple Japanese kana keyboard.yarn lint,clang-format --dry-run --Werroron both changed files, andgit diff --checkpass.Reproduction, source/binary hashes, XCTest summaries, and raw screenshots
Physical devices, other iOS versions/keyboards, candidate selection/reconversion, and Grok itself remain untested. This is not a fix for every Japanese/CJK input issue. Full monorepo JS tests/build were not run; dependency audit reports pre-existing findings, with no dependency changes in this PR. Details are in the linked verification notes.