Repository navigation
Conversation
Every push to main uploads a full copy of every screenshot under its own commit, ~3.5MB a push, so storage grows with pushes rather than with visual changes. Baseline images are now stored once at `blobs/<sha256>.png`, and each commit's manifest (marked `imageStore: 'blobs'`) refers to them by hash. A push only uploads its manifests and any images not already in `blobs/`. Older baselines without `imageStore` are still read from their per-commit paths. Changelog: [Internal]
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces storage and upload volume for E2E screenshot testing.
Currently, for simplicity, every push to
mainuploads a full copy of every screenshot under its own commit - ~3.5MB a push for ~50 tests across both platforms - so storage grows with pushes rather than with visual changes.This stores each baseline image once at
blobs/<sha256>.png, and each commit's manifest refers to its images by hash. A push uploads its manifests plus only the images not already inblobs/, so one with no visual change publishes a few KB. Manifests are still uploaded last, so a baseline only exists once its images do.Older baselines are still read from their per-commit paths, so there's nothing to migrate. Nothing expires
baselines/orblobs/.We plan to move storage backends, so I'd land this before we switch and we'll just have a clean base in the new backend. (Note this wouldn't have been possible with backends that enforce expiry, but GCP is fine)
Changelog: [Internal]
Test plan:
New unit tests. Checked against the real bucket that an existing baseline still resolves from its old path, and that a missing blob is detected. The first real publish will be the first push to
mainafter this lands.