Repository navigation
Add ReactTextView regression test for effect spans without remeasure - #59769
Open
Abbondanzo wants to merge 2 commits into
Open
Abbondanzo wants to merge 2 commits into
Abbondanzo wants to merge 2 commits into
Conversation
…oad the correct commit data. Differential Revision: D129144546
Summary: A frame-preserving text update can reach `ReactTextView.onDraw` without a `Layout`, in which case effect spans (underline, strikethrough) were skipped and only plain text painted. This pins the corrected behavior: after `setText` carrying an effect span with no intervening measure, drawing still invokes the span hooks. Changelog: [Internal] Differential Revision: D129186364
meta-cla
Bot
added
the
CLA Signed
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D129186364. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
A frame-preserving text update can reach
ReactTextView.onDrawwithout aLayout, in which case effect spans (underline, strikethrough) were skipped and only plain text painted. This pins the corrected behavior: aftersetTextcarrying an effect span with no intervening measure, drawing still invokes the span hooks.Changelog: [Internal]
Differential Revision: D129186364