Skip to content

Restore stable 9.4 versioning on release/9.x#1123

Merged
JakenVeina merged 1 commit into
reactivemarbles:release/9.xfrom
dwcullop:fix/release-9x-stable-versioning
Jun 30, 2026
Merged

Restore stable 9.4 versioning on release/9.x#1123
JakenVeina merged 1 commit into
reactivemarbles:release/9.xfrom
dwcullop:fix/release-9x-stable-versioning

Conversation

@dwcullop

Copy link
Copy Markdown
Member

Problem

release/9.x cannot publish. PR #1088 overwrote this branch''s version.json with main''s preview line, so HEAD declares "version": "9.5-preview.{height}". NBGV computes 9.5.0-preview.2, and the policy step in release.yml refuses to publish a prerelease from a release/*.x branch, so the branch is stuck.

Fix

Restore the stable form. This branch ships stable 9.4.x, and the latest published version (the tag on this repo and the package on NuGet.org) is 9.4.31:

"version": "9.4",
"versionHeightOffset": 31,

The base-version flip 9.4 -> 9.5 -> 9.4 resets NBGV''s git height to 1 on the commit that re-introduces 9.4, so the offset is required to keep the patch number continuous.

Verification

nbgv get-version, evaluated on the post-merge topology (one commit on the current HEAD, on a release/9.x ref):

Field Value
SemVer2 9.4.32
PrereleaseVersion (empty)
PublicRelease True

Next publish is a clean stable 9.4.32, continuing from 9.4.31. Offset 31 is the minimum safe value; 30 would compute 9.4.31 and collide with the existing release.

Label

Labeled manual-version-edit so pr-version-check.yml permits the hand edit. This is the recovery case the label is documented for.

@dwcullop dwcullop added the manual-version-edit PR legitimately edits version.json by hand. Bypasses pr-version-check manual-edit guard. label Jun 30, 2026
@JakenVeina JakenVeina merged commit 767f273 into reactivemarbles:release/9.x Jun 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual-version-edit PR legitimately edits version.json by hand. Bypasses pr-version-check manual-edit guard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants