K8s: creating 8.0 and 8.0.18 versions#3396
Conversation
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 6 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 79240e4. Configure here.
| 1. Patch the REAADB spec to add the new RERC name to the `participatingClusters`, replacing `<reaadb-name>` and `<rerc-name>` with your own values. | ||
|
|
||
| ```sh | ||
| kubectl patch reaadb <reaadb-name> < --type merge --patch '{"spec": {"participatingClusters": [{"name": "<rerc-name>"}]}}' |
There was a problem hiding this comment.
Invalid kubectl patch redirect
High Severity
The documented kubectl patch command includes a stray < before --type merge, which makes the shell treat it as input redirection instead of patch flags, so the command fails when readers follow the add-cluster steps.
Reviewed by Cursor Bugbot for commit 79240e4. Configure here.
| 1. Patch the REAADB spec to add the new RERC name to the `participatingClusters`, replacing `<reaadb-name>` and `<rerc-name>` with your own values. | ||
|
|
||
| ```sh | ||
| kubectl patch reaadb <reaadb-name> < --type merge --patch '{"spec": {"participatingClusters": [{"name": "<rerc-name>"}]}}' |
There was a problem hiding this comment.
Patch replaces all participating clusters
High Severity
The step to add a cluster tells readers to merge-patch participatingClusters with a single-element array. A strategic merge on that field replaces the entire list, removing existing participants instead of appending the new RERC.
Reviewed by Cursor Bugbot for commit 79240e4. Configure here.
| enabled: true | ||
| flashStorageClassName: local-flash | ||
| flashDiskSize: 100Gi | ||
| storageEngine: speedb |
There was a problem hiding this comment.
Wrong REC Flex field names
High Severity
The Flex REC example and field table use flashStorageClassName and storageEngine, but the 8.0.18 redisOnFlashSpec API documents storageClassName and bigStoreDriver. Applied YAML will not match the CRD.
Reviewed by Cursor Bugbot for commit 79240e4. Configure here.
| --namespace <namespace-name> \ | ||
| --create-namespace | ||
| --set <key1>=<value1> \ | ||
| --set <key2>=<value2> |
There was a problem hiding this comment.
Helm install missing line continuation
Medium Severity
The multi-line helm install example omits a trailing backslash after --create-namespace, so the following --set lines are not part of the command and the documented install fails if copied literally.
Reviewed by Cursor Bugbot for commit 79240e4. Configure here.
|
|
||
| - Redis Enterprise for Kubernetes version 8.0.2-2 or later installed | ||
| - A running `RedisEnterpriseCluster` (REC) resource | ||
| - Redis database version 7.4 or later |
There was a problem hiding this comment.
Flex get-started contradicts itself
Medium Severity
The page opens with a note directing 8.0+ readers elsewhere and claims Auto Tiering scope, while the body is the 8.0.18 Flex guide requiring operator 8.0.2-2+. Prerequisites also cite Redis DB 7.4+, conflicting with plan.md requiring 8.2+.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 79240e4. Configure here.
|
|
||
| 1. Increase `memorySize` in the `spec` section. | ||
|
|
||
| 1. Decrease `rofRamSize` in the `redisOnFlashSpec` section. |
There was a problem hiding this comment.
REDB field path wrong in scale
Medium Severity
Scaling steps tell readers to change rofRamSize under a redisOnFlashSpec section on the REDB, but rofRamSize belongs on spec for RedisEnterpriseDatabase, not under REC-only redisOnFlashSpec.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 79240e4. Configure here.
andy-stark-redis
left a comment
andy-stark-redis
left a comment
There was a problem hiding this comment.
Builds OK locally and seems to have the correct Puny Banners for a random selection of a few pages, so... approved.
2 participants
Duckburg release will include breaking changes, so I can't put all 8.0 releases into the same version, or wait until we move to 8.1 to version it.
Note
Cursor Bugbot is generating a summary for commit 79240e4. Configure here.