Repository navigation
👷♀️ Ask the registry whether a version is published - #20
Merged
Merged
Conversation
alecgibson
force-pushed
the
fix-release-script
branch
from
September 15, 2026 09:24
9a2ed24 to
7c962ea
Compare
alecgibson
changed the title
latest dist-tag, and fail the release loudly
`release.sh` asked git whether a version had been released, then published to npm — two owners of one fact. A publish that failed after the tag landed left the version tagged but unpublished, and the guard skipped it on every later run; that is how `4.1.0-reedsy.5.0.0` came to need a tag deleted by hand. The registry answers that now, and publishing comes first, so a failed publish leaves nothing behind and simply retries. Tagging afterwards is best-effort: nothing but us reads these tags, so a missing one is worth a warning rather than a red build. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
alecgibson
force-pushed
the
fix-release-script
branch
from
September 15, 2026 09:35
7c962ea to
d7fb339
Compare
alecgibson
marked this pull request as ready for review
September 15, 2026 09:38
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Updates release detection to use npm as the source of truth, publishes before tagging, and makes tagging best-effort.
Changes:
- Checks whether the exact version is published.
- Publishes before creating and pushing the Git tag.
- Adds shell syntax validation to CI.
File summaries
| File | Description |
|---|---|
release.sh |
Implements registry-based release detection and publish-first ordering. |
.github/workflows/ci.yml |
Validates the release script syntax in CI. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release.shasked git whether a version had been released, then published to npm — two owners of one fact. A publish that failed after the tag landed left the version tagged but unpublished, and the guard skipped it on every later run; that is how4.1.0-reedsy.5.0.0came to need a tag deleted by hand.The registry answers that now, and publishing comes first, so a failed publish leaves nothing behind and simply retries. Tagging afterwards is best-effort: nothing but us reads these tags, so a missing one is worth a warning rather than a red build.
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com