[simonkrogmann]

Purpose of this PR

To make the Remind folder more clean and results easier to find most comparison scripts are now creating files in the directory output instead of on the top level.

I did not change comparison scripts I could not get to work:

• checkClimatePercentiles
• plot_compare_iterations
• supplycurves

More changes:

• added a test of compareScenarios2 (a stripped down version that takes 7 seconds).
• removed the script runtime and varListHtml as they seem to be broken for years and the former possibly replaced by plotRuntime.

It might be useful to collect some feedback from the heavier users before merging.

Type of change

Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.

Parts concerned

• ◻️ GAMS Code
• ☑️ R-scripts
• ◻️ Documentation (GAMS incode documentation, comments, tutorials)
• ◻️ Input data / CES parameters
• ☑️ Tests, CI/CD (continuous integration/deployment)
• ◻️ Configuration (switches in main.gms, default.cfg, and scenario_config*.csv files)
• ◻️ Other (please give a description)

Impact

• ◻️ Bug fix
• ☑️ Refactoring
• ◻️ New feature
• ◻️ Change of parameter values or input data (including CES parameters)
• ◻️ Minor change (default scenarios show only small differences)
• ◻️ Fundamental change of results of default scenarios

Checklist

Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.

• I executed the automated model tests (make test) after my final commit and all tests pass (FAIL 0)
• I adjusted the reporting in remind2 if and where it was needed
• I adjusted the madrat packages (mrremind and other packages involved) for input data generation if and where it was needed
• My code follows the coding etiquette
• I explained my changes within the PR, particularly in hard-to-understand areas
• I checked that the in-code documentation is up-to-date
• I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
• I updated the CHANGELOG.md correctly (added, changed, fixed, removed, input data/calibration)

Further information (optional)

[fbenke-pik]

Event though fixing varListHtml isn't hard, I think you should delete it. The main user and author of this script has left a long time ago.

[fbenke-pik]

Did you test each script you touched?

[simonkrogmann]

Yes, although not extensively.