Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-interactive commands that require confirmation write their prompt and cancellation notice to stdout, corrupting
--output jsoneven when the user accepts. When stdin is closed, the command instead returns a bareEOFwithout explaining the required confirmation.Send confirmation prompts and cancellation notices to stderr, and wrap confirmation EOF with guidance to rerun with
--confirm. Preserve the confirmation gate and the underlying EOF for error inspection. Regression tests cover closed/unterminated stdin, acceptance, decline, explicit confirmation, other read failures, and deployment creation with JSON output under TTY and non-TTY runtime signals. The deployment tests verify that no POST occurs before confirmation and that confirmed requests forward the commit and return clean JSON.Validation:
go test ./cmd/... ./pkg/... ./internal/...go test -race ./cmd ./pkg/command -run 'TestDeployCreateJSONConfirmation|TestNonInteractiveWithConfirm' -count=1git diff --check