Repository navigation
Reject eval in expression-only parsing - #1223
Merged
Merged
Conversation
Contributor
Author
|
thanks for taking this one, glad the expression path is closed off now. |
Collaborator
|
I'm wondering... Can we still support Probably not as the AST does not retain such info. It is all caught at compile time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eval_expressionrejects assignments, butevalinside the expression does not:The Book says expression-only evaluation allows no statements, "not even variable assignment", and no loops.
parse_global_exprenforces that withDISALLOW_STATEMENTS_IN_BLOCKS, butparse_fn_callstill accepts a call toeval, which compiles its argument as a full script and runs it in the caller's scope. So an expression from an untrusted user can assign to the host's scope variables, runeval("while true {}"), oreval("import \"/path/file\" as m; m::f()")to load and run a script file through the defaultFileModuleResolver.The check sits in
parse_fn_callbecause that flag is set only for expression-only parsing and closures inside an expression inherit it, so[1].map(|v| eval(...))is rejected too. Full scripts are unaffected.Engine::parse_jsonalso parses throughparse_global_expr, soevalin JSON text is rejected as well; #1221 deals with function calls there in general.